You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Pengzna (via GitHub)" <gi...@apache.org> on 2024/06/23 13:54:22 UTC
[PR] PipeConsensus: fix concurrent problems regarding to initiate receiver and progressIndex & optimize receiver logs [iotdb]
Pengzna opened a new pull request, #12790:
URL: https://github.com/apache/iotdb/pull/12790
as title.
this pr will fix TIMECHO-771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PipeConsensus: fix concurrent problems regarding to initiate receiver and progressIndex & optimize receiver logs & fix npe [iotdb]
Posted by "Pengzna (via GitHub)" <gi...@apache.org>.
Pengzna commented on code in PR #12790:
URL: https://github.com/apache/iotdb/pull/12790#discussion_r1650409707
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/consensus/ProgressIndexDataNodeManager.java:
##########
@@ -74,9 +74,13 @@ private void recoverMaxProgressIndexFromDataRegion() {
maxProgressIndex.updateToMinimumEqualOrIsAfterProgressIndex(
extractLocalSimpleProgressIndex(progressIndex));
}
- groupId2MaxProgressIndex
- .computeIfAbsent(dataRegionId, o -> MinimumProgressIndex.INSTANCE)
- .updateToMinimumEqualOrIsAfterProgressIndex(maxProgressIndex);
+ ProgressIndex correspondingProgressIndex =
+ groupId2MaxProgressIndex
+ .computeIfAbsent(dataRegionId, o -> MinimumProgressIndex.INSTANCE)
+ .updateToMinimumEqualOrIsAfterProgressIndex(maxProgressIndex);
+ // Need to update map by hand due to the syntax of
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PipeConsensus: fix concurrent problems regarding to initiate receiver and progressIndex & optimize receiver logs & fix npe [iotdb]
Posted by "Caideyipi (via GitHub)" <gi...@apache.org>.
Caideyipi commented on code in PR #12790:
URL: https://github.com/apache/iotdb/pull/12790#discussion_r1650302923
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/consensus/ProgressIndexDataNodeManager.java:
##########
@@ -74,9 +74,13 @@ private void recoverMaxProgressIndexFromDataRegion() {
maxProgressIndex.updateToMinimumEqualOrIsAfterProgressIndex(
extractLocalSimpleProgressIndex(progressIndex));
}
- groupId2MaxProgressIndex
- .computeIfAbsent(dataRegionId, o -> MinimumProgressIndex.INSTANCE)
- .updateToMinimumEqualOrIsAfterProgressIndex(maxProgressIndex);
+ ProgressIndex correspondingProgressIndex =
+ groupId2MaxProgressIndex
+ .computeIfAbsent(dataRegionId, o -> MinimumProgressIndex.INSTANCE)
+ .updateToMinimumEqualOrIsAfterProgressIndex(maxProgressIndex);
+ // Need to update map by hand due to the syntax of
Review Comment:
use "manually" instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PipeConsensus: fix concurrent problems regarding to initiate receiver and progressIndex & optimize receiver logs & fix npe [iotdb]
Posted by "Pengzna (via GitHub)" <gi...@apache.org>.
Pengzna commented on PR #12790:
URL: https://github.com/apache/iotdb/pull/12790#issuecomment-2185560438
@OneSizeFitsQuorum @Caideyipi PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org