You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/08 14:55:11 UTC
[jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report
metric names with invalid characters
[ https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367779#comment-15367779 ]
ASF GitHub Bot commented on FLINK-4184:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2220
[FLINK-4184] [metrics] Replace invalid characters in ScheduledDropwizardReporter
The GraphiteReporter and GangliaReporter report metric names which can contain invalid
characters. These characters include quotes and dots. In order to properly report metrics
to these systems, the afore-mentioned characters have to be replaced in metric names.
The PR also removes quotes from the garbage collector metric name.
The PR sets the default value for TTL in the GangliaReporter to 1, because -1 causes the
reporter to fail.
R @zentol.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixDropwizardReporters
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2220.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2220
----
commit d63911499aef10f54d7c4c0774f4f22a520bcc66
Author: Till Rohrmann <tr...@apache.org>
Date: 2016-07-08T14:41:39Z
[FLINK-4184] [metrics] Replace invalid characters in ScheduledDropwizardReporter
The GraphiteReporter and GangliaReporter report metric names which can contain invalid
characters. These characters include quotes and dots. In order to properly report metrics
to these systems, the afore-mentioned characters have to be replaced in metric names.
The PR also removes quotes from the garbage collector metric name.
The PR sets the default value for TTL in the GangliaReporter to 1, because -1 causes the
reporter to fail.
----
> Ganglia and GraphiteReporter report metric names with invalid characters
> ------------------------------------------------------------------------
>
> Key: FLINK-4184
> URL: https://issues.apache.org/jira/browse/FLINK-4184
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with names which contain invalid characters. For example, quotes are not filtered out which can be problematic for Ganglia. Moreover, dots are not replaced which causes Graphite to think that an IP address is actually a scoped metric name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)