You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Superskyyy (via GitHub)" <gi...@apache.org> on 2023/04/26 04:54:20 UTC
[GitHub] [skywalking] Superskyyy opened a new issue, #10734: [Feature] Python agent support printing TID to logs
Superskyyy opened a new issue, #10734:
URL: https://github.com/apache/skywalking/issues/10734
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
This is a simple but missing advanced feature that Java agent already supports, there is a TODO in the Python agent codebase for this. Should be very easy to implement (fewer than 10 lines of code?), so it's open for new contributors to try.
### Use case
User should be able to see output logs containing traceid, see https://skywalking.apache.org/docs/skywalking-java/next/en/setup/service-agent/java-agent/application-toolkit-logback-1.x/
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Superskyyy commented on issue #10734: [Feature] Python agent support printing TID to logs
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on issue #10734:
URL: https://github.com/apache/skywalking/issues/10734#issuecomment-1537548220
> Hello! This seems like a good starting point for my open source contribution journey. Can you guide me how to solve this issue?
Hello there! Welcome to the SkyWalking community. To get started on implementing this feature, it would be the best if you could try and understand how this feature works in our Java agent equivalent, then you should go to our Python agent implmentation of log reporter, where you will find most of the code already written to correlate logs with tracing contexts.
As a result, you will need to write new code to use a [LoggerAdapter](https://docs.python.org/3/howto/logging-cookbook.html#context-info) to inject the current traceIDs (https://github.com/apache/skywalking-python/blob/master/skywalking/log/sw_logging.py) into the logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ansuman-satapathy commented on issue #10734: [Feature] Python agent support printing TID to logs
Posted by "ansuman-satapathy (via GitHub)" <gi...@apache.org>.
ansuman-satapathy commented on issue #10734:
URL: https://github.com/apache/skywalking/issues/10734#issuecomment-1537343099
Hello! This seems like a good starting point for my open source contribution journey. Can you guide me how to solve this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ansuman-satapathy commented on issue #10734: [Feature] Python agent support printing TID to logs
Posted by "ansuman-satapathy (via GitHub)" <gi...@apache.org>.
ansuman-satapathy commented on issue #10734:
URL: https://github.com/apache/skywalking/issues/10734#issuecomment-1545073917
Is this correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ansuman-satapathy commented on issue #10734: [Feature] Python agent support printing TID to logs
Posted by "ansuman-satapathy (via GitHub)" <gi...@apache.org>.
ansuman-satapathy commented on issue #10734:
URL: https://github.com/apache/skywalking/issues/10734#issuecomment-1592234524
> @ansuman-satapathy Updates?
Apologies for the delay. Actually I have been really busy with exams & college. But now my exams are over. So I will start doing this again. I hope you understand. Also If this issue is really important, please assign it to someone with more experience since I am really slow with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ansuman-satapathy commented on issue #10734: [Feature] Python agent support printing TID to logs
Posted by "ansuman-satapathy (via GitHub)" <gi...@apache.org>.
ansuman-satapathy commented on issue #10734:
URL: https://github.com/apache/skywalking/issues/10734#issuecomment-1545158815
Okay, I will try to learn more about this and get back to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ansuman-satapathy commented on issue #10734: [Feature] Python agent support printing TID to logs
Posted by "ansuman-satapathy (via GitHub)" <gi...@apache.org>.
ansuman-satapathy commented on issue #10734:
URL: https://github.com/apache/skywalking/issues/10734#issuecomment-1691644177
> Hi @ansuman-satapathy, are you still working on this one ?
No man, been busy. Feel free to take it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Superskyyy commented on issue #10734: [Feature] Python agent support printing TID to logs
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on issue #10734:
URL: https://github.com/apache/skywalking/issues/10734#issuecomment-1539422086
> Thank you. I will try my best to solve this issue. I might ask some more questions in the future as I am quite new to all of this.
Cool, I will monitor this issue as you proceed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] Python agent support printing TID to logs [skywalking]
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy closed issue #10734: [Feature] Python agent support printing TID to logs
URL: https://github.com/apache/skywalking/issues/10734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ansuman-satapathy commented on issue #10734: [Feature] Python agent support printing TID to logs
Posted by "ansuman-satapathy (via GitHub)" <gi...@apache.org>.
ansuman-satapathy commented on issue #10734:
URL: https://github.com/apache/skywalking/issues/10734#issuecomment-1545057183
Hello! I am getting the following error while building dependencies in maven. I think I am missing something here. Can you point me to some other resources from which I can learn about all of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Superskyyy commented on issue #10734: [Feature] Python agent support printing TID to logs
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on issue #10734:
URL: https://github.com/apache/skywalking/issues/10734#issuecomment-1596435163
> > @ansuman-satapathy Updates?
>
> Apologies for the delay. Actually I have been really busy with exams & college. But now my exams are over. So I will start doing this again. I hope you understand. Also If this issue is really important, please assign it to someone with more experience since I am really slow with it.
Okay! Take your time, I will update here if anyone picks this up. Remember to put a note here if you decided to continue on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10734: [Feature] Python agent support printing TID to logs
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10734:
URL: https://github.com/apache/skywalking/issues/10734#issuecomment-1545058969
How do you declare the version of the dependency? ${project.release.version} should be replaced by a specific released version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Superskyyy commented on issue #10734: [Feature] Python agent support printing TID to logs
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on issue #10734:
URL: https://github.com/apache/skywalking/issues/10734#issuecomment-1592180754
@ansuman-satapathy Updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] mohitsatr commented on issue #10734: [Feature] Python agent support printing TID to logs
Posted by "mohitsatr (via GitHub)" <gi...@apache.org>.
mohitsatr commented on issue #10734:
URL: https://github.com/apache/skywalking/issues/10734#issuecomment-1691588700
Hi @ansuman-satapathy, are you still working on this one ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] Python agent support printing TID to logs [skywalking]
Posted by "CodePrometheus (via GitHub)" <gi...@apache.org>.
CodePrometheus commented on issue #10734:
URL: https://github.com/apache/skywalking/issues/10734#issuecomment-1752038813
@Superskyyy hi, please assign to me, I want to try it. BTW, I want to confirm whether this task allows skywalking/loggings.py to have the ability to output TIDs to logs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10734: [Feature] Python agent support printing TID to logs
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10734:
URL: https://github.com/apache/skywalking/issues/10734#issuecomment-1545077151
I usually changed the pom.xml directly. Don't know much about setting this on IDEA UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ansuman-satapathy commented on issue #10734: [Feature] Python agent support printing TID to logs
Posted by "ansuman-satapathy (via GitHub)" <gi...@apache.org>.
ansuman-satapathy commented on issue #10734:
URL: https://github.com/apache/skywalking/issues/10734#issuecomment-1538491823
Thank you. I will try my best to solve this issue. I might ask some more questions in the future as I am quite new to all of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] Python agent support printing TID to logs [skywalking]
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on issue #10734:
URL: https://github.com/apache/skywalking/issues/10734#issuecomment-1755894773
@CodePrometheus Hi, yes the feature you implemented sounds like on the point, please do raise the PR and I will take a look. Thanks a lot for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] Python agent support printing TID to logs [skywalking]
Posted by "CodePrometheus (via GitHub)" <gi...@apache.org>.
CodePrometheus commented on issue #10734:
URL: https://github.com/apache/skywalking/issues/10734#issuecomment-1755763240
@wu-sheng Hello Teacher Wu, please assign to me. I have implemented the python agent to print the traceId in the logs. I want to confirm whether it is the expected goal of the task. If so, I will immediately initiate a PR later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org