You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/05/24 16:06:12 UTC
[kudu-CR] [java] Add Timestamp APIs to kudu-client
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10502
Change subject: [java] Add Timestamp APIs to kudu-client
......................................................................
[java] Add Timestamp APIs to kudu-client
Adds support for java.sql.Timestamp to PartialRow,
RowResult, and KuduPredicate. This simplifies and
unfies the handling of Timestamps when reading
and writing from Kudu.
This functionality existied in the kudu-spark
integration, but has been moved into the kudu-client
and can be leveraged in other integrations going
forward.
Change-Id: I1fdd397691f12f279663838af9fa12ed27508fd1
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
A java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
A java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
13 files changed, 280 insertions(+), 104 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/10502/1
--
To view, visit http://gerrit.cloudera.org:8080/10502
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1fdd397691f12f279663838af9fa12ed27508fd1
Gerrit-Change-Number: 10502
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [java] Add Timestamp APIs to kudu-client
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10502 )
Change subject: [java] Add Timestamp APIs to kudu-client
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10502/2/java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java
File java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java:
http://gerrit.cloudera.org:8080/#/c/10502/2/java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java@50
PS2, Line 50: public void testNonZuluTimestampConversion() throws Exception {
> Is this testing any Kudu functionality? I was pretty thoroughly confused w
To some degree it's not, but it demonstrates and proves that the timezone doesn't matter when converting between micros, timestamps, and strings. I think at a minimum it's a valid illustration of the potential use.
--
To view, visit http://gerrit.cloudera.org:8080/10502
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fdd397691f12f279663838af9fa12ed27508fd1
Gerrit-Change-Number: 10502
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 31 May 2018 15:35:22 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Add Timestamp APIs to kudu-client
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10502 )
Change subject: [java] Add Timestamp APIs to kudu-client
......................................................................
Patch Set 2:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java:
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@557
PS1, Line 557: * @throws IllegalStateException if the row was already applied
> Document how java.sql.Timestamp instances with nanosecond precision are tru
Done
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@566
PS1, Line 566: }
> ditto
Done
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@586
PS1, Line 586: * @param columnName name of the column to get data for
> Probably worth documenting that all returned values will be in the UTC time
I don't think java.sql.Timestamp objects have time zones. A timezone is only "applied" when formatting a Timestamp (or Date) with something like SimpleDateFormat.
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@593
PS1, Line 593: }
> ditto
Done
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java:
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@354
PS1, Line 354: * @return a Timestamp
> Update
Done
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@366
PS1, Line 366: * @return a Timestamp
> likewise
Done
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java:
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java@42
PS1, Line 42: * Converts a {@link Timestamp} to microseconds since the Unix epoch (1970-01-01T00:00:00Z).
> I think the brackets are scaladoc specific. Javadoc equivalent is @link or
Done
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java@60
PS1, Line 60:
> likewise
Done
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java@83
PS1, Line 83: * @param micros the timestamp, in microseconds
> Shouldn't be necessary to have both versions of this helper anymore, since
Done
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java:
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java@36
PS1, Line 36: public class TestPartialRow {
> Add a tests that writes a timestamp with a non-zulu offset and ensure it's
I can write this test in TestTimestampUtil by round-tripping the conversion to and from micros.
--
To view, visit http://gerrit.cloudera.org:8080/10502
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fdd397691f12f279663838af9fa12ed27508fd1
Gerrit-Change-Number: 10502
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 31 May 2018 15:02:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Add Timestamp APIs to kudu-client
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10502 )
Change subject: [java] Add Timestamp APIs to kudu-client
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10502/2/java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java
File java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java:
http://gerrit.cloudera.org:8080/#/c/10502/2/java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java@50
PS2, Line 50: public void testNonZuluTimestampConversion() throws Exception {
> To some degree it's not, but it demonstrates and proves that the timezone d
SGTM
--
To view, visit http://gerrit.cloudera.org:8080/10502
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fdd397691f12f279663838af9fa12ed27508fd1
Gerrit-Change-Number: 10502
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 31 May 2018 15:36:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Add Timestamp APIs to kudu-client
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Dan Burkert, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10502
to look at the new patch set (#2).
Change subject: [java] Add Timestamp APIs to kudu-client
......................................................................
[java] Add Timestamp APIs to kudu-client
Adds support for java.sql.Timestamp to PartialRow,
RowResult, and KuduPredicate. This simplifies and
unfies the handling of Timestamps when reading
and writing from Kudu.
This functionality existied in the kudu-spark
integration, but has been moved into the kudu-client
and can be leveraged in other integrations going
forward.
Change-Id: I1fdd397691f12f279663838af9fa12ed27508fd1
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
A java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
A java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
13 files changed, 304 insertions(+), 104 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/10502/2
--
To view, visit http://gerrit.cloudera.org:8080/10502
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1fdd397691f12f279663838af9fa12ed27508fd1
Gerrit-Change-Number: 10502
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [java] Add Timestamp APIs to kudu-client
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10502 )
Change subject: [java] Add Timestamp APIs to kudu-client
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java:
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@586
PS1, Line 586: * @param columnName name of the column to get data for
> I don't think java.sql.Timestamp objects have time zones. A timezone is onl
Woops you're absolutely right. Got myself confused reading JDK docs yesterday.
http://gerrit.cloudera.org:8080/#/c/10502/2/java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java
File java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java:
http://gerrit.cloudera.org:8080/#/c/10502/2/java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java@50
PS2, Line 50: public void testNonZuluTimestampConversion() throws Exception {
Is this testing any Kudu functionality? I was pretty thoroughly confused when I suggested the non-zulu timestamp test (given Timestamp instances don't have timezones).
--
To view, visit http://gerrit.cloudera.org:8080/10502
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fdd397691f12f279663838af9fa12ed27508fd1
Gerrit-Change-Number: 10502
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 31 May 2018 15:22:47 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Add Timestamp APIs to kudu-client
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10502 )
Change subject: [java] Add Timestamp APIs to kudu-client
......................................................................
[java] Add Timestamp APIs to kudu-client
Adds support for java.sql.Timestamp to PartialRow,
RowResult, and KuduPredicate. This simplifies and
unfies the handling of Timestamps when reading
and writing from Kudu.
This functionality existied in the kudu-spark
integration, but has been moved into the kudu-client
and can be leveraged in other integrations going
forward.
Change-Id: I1fdd397691f12f279663838af9fa12ed27508fd1
Reviewed-on: http://gerrit.cloudera.org:8080/10502
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
A java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
A java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
13 files changed, 304 insertions(+), 104 deletions(-)
Approvals:
Kudu Jenkins: Verified
Dan Burkert: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10502
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fdd397691f12f279663838af9fa12ed27508fd1
Gerrit-Change-Number: 10502
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [java] Add Timestamp APIs to kudu-client
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10502 )
Change subject: [java] Add Timestamp APIs to kudu-client
......................................................................
Patch Set 1:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java:
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@557
PS1, Line 557: public void addTimestamp(int columnIndex, Timestamp val) {
Document how java.sql.Timestamp instances with nanosecond precision are truncated or otherwise made to be written to Kudu's timestamp type, which is microsecond precise.
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@566
PS1, Line 566: * Add a Timestamp for the specified column.
ditto
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@586
PS1, Line 586: public Timestamp getTimestamp(String columnName) {
Probably worth documenting that all returned values will be in the UTC timezone offset (+0), which may be confusing since values can be written with any timezone offset.
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@593
PS1, Line 593: * @param columnIndex Column index in the schema
ditto
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java:
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@354
PS1, Line 354: * @return a BigDecimal
Update
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@366
PS1, Line 366: * @return a BigDecimal
likewise
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java:
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java@42
PS1, Line 42: * Converts a [[Timestamp]] to microseconds since the Unix epoch (1970-01-01T00:00:00Z).
I think the brackets are scaladoc specific. Javadoc equivalent is @link or something like that
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java@60
PS1, Line 60: [[Timestamp]
likewise
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java@83
PS1, Line 83: public static String timestampToString(long micros) {
Shouldn't be necessary to have both versions of this helper anymore, since the caller of the other version could use the alternate getter.
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java:
http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java@36
PS1, Line 36: public class TestPartialRow {
Add a tests that writes a timestamp with a non-zulu offset and ensure it's properly handled.
--
To view, visit http://gerrit.cloudera.org:8080/10502
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fdd397691f12f279663838af9fa12ed27508fd1
Gerrit-Change-Number: 10502
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 30 May 2018 21:35:47 +0000
Gerrit-HasComments: Yes