You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/11 17:05:00 UTC
[jira] [Commented] (CB-12361) Speed up cordova-lib tests
[ https://issues.apache.org/jira/browse/CB-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123640#comment-16123640 ]
ASF GitHub Bot commented on CB-12361:
-------------------------------------
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/582#discussion_r132736159
--- Diff: spec/cordova/plugin/search.spec.js ---
@@ -44,7 +44,36 @@ describe('cordova/plugin/search', function () {
console.error(e);
}).done(done);
});
- it('should open a link to cordova.apache.org/plugins if no plugins are provided as parameter');
- it('should open a link to cordova.apache.org/plugins, providing the plugins passed in as a query-string parameter');
- it('should fire the after_plugin_search hook');
+
+ it('should open a link to cordova.apache.org/plugins if no plugins are provided as parameter', function (done) {
+ var opts = {important: 'options', plugins: []};
+ search(hook_mock, opts).then(function () {
+ expect(opener_mock).toHaveBeenCalled();
+ }).fail(function (e) {
+ console.log(e);
+ fail('fail handler unexpectedly invoked');
+ console.error(e);
+ }).done(done);
+ });
+
+ it('should open a link to cordova.apache.org/plugins, providing the plugins passed in as a query-string parameter', function (done) {
+ var opts = {important: 'options', plugins: ['cordova-plugin-camera', 'cordova-plugin-splashscreen']};
+ search(hook_mock, opts).then(function () {
+ expect(opener_mock).toHaveBeenCalled();
+ }).fail(function (e) {
+ console.log(e);
--- End diff --
same
> Speed up cordova-lib tests
> --------------------------
>
> Key: CB-12361
> URL: https://issues.apache.org/jira/browse/CB-12361
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
> Reporter: Steve Gill
> Assignee: Steve Gill
> Labels: cordova-next
>
> * Split out e2e tests into own folder
> * stub i/o and network requests
> * use local fixtures when possible & makes sense
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org