[jira] Commented: (DERBY-2150) Reduce use of synchronized collections in GenericLanguageConnectionContext

["Knut Anders Hatlen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463562 ] 

Knut Anders Hatlen commented on DERBY-2150:
-------------------------------------------

I have uploaded a new version of the patch (1b) which preserves the
space optimization which previously was implemented with
Vector.capacity() and Vector.trimToSize(). I have not found any way to
manipulate the Vectors without having synchronized on the connection
first, so I believe it is safe to replace them with vectors.

Derbyall and JUnit tests ran cleanly on the updated patch. Reviews
would be appreciated. Thanks!

> Reduce use of synchronized collections in GenericLanguageConnectionContext
> --------------------------------------------------------------------------
>
>                 Key: DERBY-2150
>                 URL: https://issues.apache.org/jira/browse/DERBY-2150
>             Project: Derby
>          Issue Type: Improvement
>          Components: Performance, SQL
>    Affects Versions: 10.3.0.0
>            Reporter: Knut Anders Hatlen
>         Assigned To: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: derby-2150-1a.diff, derby-2150-1b.diff
>
>
> In org.apache.derby.impl.sql.conn.GenericLanguageConnectionContext, it is probably safe to replace some of the synchronized collections with unsynchronized ones. This should be investigated, and the unnecessary synchronization should be removed. See discussion here: http://www.nabble.com/Use-of-synchronized-containers-in-engine-code-tf2754469.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira