You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/09/30 16:13:11 UTC
[GitHub] [hive] szlta opened a new pull request #1541: HIVE-21375 initial commit
szlta opened a new pull request #1541:
URL: https://github.com/apache/hive/pull/1541
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] szlta commented on pull request #1541: HIVE-21375 initial commit
Posted by GitBox <gi...@apache.org>.
szlta commented on pull request #1541:
URL: https://github.com/apache/hive/pull/1541#issuecomment-702591651
Cherry-picked changes here that allow test run on this PR. There were many test failures as branch-3 is in bad shape currently, but none of those seemed to be related to hcatalog streaming, thus I'm moving forward with this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #1541: HIVE-21375 initial commit
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #1541:
URL: https://github.com/apache/hive/pull/1541#discussion_r497650656
##########
File path: hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java
##########
@@ -1107,4 +1114,37 @@ private static void setHiveConf(HiveConf conf, HiveConf.ConfVars var, boolean va
conf.setBoolVar(var, value);
}
+ private static void incRefForUgi(UserGroupInformation ugi) {
+ refCountLock.lock();
+ try {
+ Long prevCount = ugiConnectionRefCount.putIfAbsent(ugi, 1L);
+ if (prevCount != null) {
Review comment:
How can this be null?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] szlta merged pull request #1541: HIVE-21375 initial commit
Posted by GitBox <gi...@apache.org>.
szlta merged pull request #1541:
URL: https://github.com/apache/hive/pull/1541
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #1541: HIVE-21375 initial commit
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #1541:
URL: https://github.com/apache/hive/pull/1541#discussion_r497651467
##########
File path: hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java
##########
@@ -1107,4 +1114,37 @@ private static void setHiveConf(HiveConf conf, HiveConf.ConfVars var, boolean va
conf.setBoolVar(var, value);
}
+ private static void incRefForUgi(UserGroupInformation ugi) {
+ refCountLock.lock();
+ try {
+ Long prevCount = ugiConnectionRefCount.putIfAbsent(ugi, 1L);
+ if (prevCount != null) {
Review comment:
Sorry my mistake
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #1541: HIVE-21375 initial commit
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #1541:
URL: https://github.com/apache/hive/pull/1541#discussion_r497649749
##########
File path: hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java
##########
@@ -394,10 +404,12 @@ public Void run() throws Exception {
return null;
}
});
- try {
- FileSystem.closeAllForUGI(ugi);
- } catch (IOException exception) {
- LOG.error("Could not clean up file-system handles for UGI: " + ugi, exception);
+ if (decRefForUgi(ugi) == 0) {
+ try {
+ FileSystem.closeAllForUGI(ugi);
Review comment:
nit: indent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org