[GitHub] [superset] john-bodley commented on a diff in pull request #24709: fix(chore): dashboard requests to database equal the number of slices it has

["john-bodley (via GitHub)" <gi...@apache.org>]

john-bodley commented on code in PR #24709:
URL: https://github.com/apache/superset/pull/24709#discussion_r1267062291


##########
superset/daos/dashboard.py:
##########
@@ -63,8 +63,6 @@ def get_by_id_or_slug(cls, id_or_slug: int | str) -> Dashboard:
             query = (
                 db.session.query(Dashboard)
                 .filter(id_or_slug_filter(id_or_slug))
-                .outerjoin(Slice, Dashboard.slices)

Review Comment:
   @dpgaspar would you mind looking into this as it seems you added this logic in https://github.com/apache/superset/pull/22358? Note it's interesting that the unit/integration tests passed with the removal of these two lines.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org