You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/10 02:29:31 UTC
[GitHub] [flink] beyond1920 commented on a change in pull request #8294:
[FLINK-12348][table-planner-blink]Use TableConfig in api module to replace
TableConfig in blink-planner module.
beyond1920 commented on a change in pull request #8294: [FLINK-12348][table-planner-blink]Use TableConfig in api module to replace TableConfig in blink-planner module.
URL: https://github.com/apache/flink/pull/8294#discussion_r301864143
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/api/ExecutionConfigOptions.java
##########
@@ -174,16 +174,38 @@
" is set true, its value must be positive.");
// ------------------------------------------------------------------------
- // State Options
+ // Emit Strategy Options
// ------------------------------------------------------------------------
- public static final ConfigOption<String> SQL_EXEC_STATE_TTL =
- key("sql.exec.state.ttl")
- .defaultValue("-1 ms")
- .withDescription("Specifies a minimum time interval for how long idle state " +
- "(i.e. state which was not updated), will be retained. State will never be " +
- "cleared until it was idle for less than the minimum time, and will be cleared " +
- "at some time after it was idle. Default is never clean-up the state.\n" +
- "NOTE: Cleaning up state requires additional overhead for bookkeeping.");
+
+ public static final ConfigOption<Boolean> SQL_EXEC_EMIT_EARLY_FIRE_ENABLED =
Review comment:
These configuration is get/set by old TableConfig in Blink planner which is not contained by TableConfig in Api module. After remove old TableConfig in Blink planner, I move the configuration to ExecutionConfigOptions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services