You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/05/25 07:56:05 UTC
[GitHub] [incubator-ratis] runzhiwang opened a new pull request #112: RATIS-900. Fix Failed UT: RaftExceptionBaseTest.testHandleNotLeaderAndIOException
runzhiwang opened a new pull request #112:
URL: https://github.com/apache/incubator-ratis/pull/112
What's the problem ?
What's the reason ?
In the test, the cluster first select an oldLeader such as s1, then force change to newLeader such as s2, and kill s2. Then client connect to s1 and expect s1 reply the info of real leader i.e. s2 in the NotLeaderException. But the s2 has been killed, ratis will triger a leader election, leader will change from s2 to s0, then s0 was included in the NotLeaderException rather than s2. so the test failed.
How to fix ?
I think this UT is outdated. We can not expect the leader will not change if we kill the leader.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang commented on pull request #112: RATIS-900. Fix Failed UT: RaftExceptionBaseTest.testHandleNotLeaderAndIOException
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #112:
URL: https://github.com/apache/incubator-ratis/pull/112#issuecomment-633444609
@bshashikant @lokeshj1703 Could you help review this patch ? Thank you very much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] bshashikant merged pull request #112: RATIS-900. Fix Failed UT: RaftExceptionBaseTest.testHandleNotLeaderAndIOException
Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #112:
URL: https://github.com/apache/incubator-ratis/pull/112
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org