[I] Clean up definitions in code of processing element types

["bossenti (via GitHub)" <gi...@apache.org>]

bossenti opened a new issue, #2054:
URL: https://github.com/apache/streampipes/issues/2054

   ### Body
   
   At multiple places in our codebase, we need to distinguish the different types of processing elements (adapter, data processors, and sinks) and other StreamPipes entities/concepts.
   
   For this purpose, there are already some enums defined that try to model this consistently, e.g., `PeType` and `SpServiceTagPrefix`.
   However, they are not really used consistently and have some intersections. In addition, we have some legacy identifiers like `sepa` hard-coded across our codebase.
   
   This issue seeks towards a unification of the existing concepts and the removal of hard-coded references. 
   A possible solution would be to introduce a joined enum in `streampipes-model` that supports also old/legacy values with a custom function. This allows us to replace hard-coded values step by step and in the end remove the legacy usage completely.
   
   ### StreamPipes Committer
   
   I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Clean up definitions in code of processing element types

["tenthe (via GitHub)" <gi...@apache.org>]

tenthe closed issue #2054: Clean up definitions in code of processing element types
URL: https://github.com/apache/streampipes/issues/2054


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Clean up definitions in code of processing element types

["alisha-1000 (via GitHub)" <gi...@apache.org>]

alisha-1000 commented on issue #2054:
URL: https://github.com/apache/streampipes/issues/2054#issuecomment-3846062228

   Hi @bossenti,
   
   I’m interested in working on this issue and had a look at the current usage of processing element type definitions across the codebase.
   
   From what I understand, the main goal here is to:
   
   unify the different representations of processing element types (e.g., adapters, processors, sinks),
   
   reduce overlap between existing enums like PeType and SpServiceTagPrefix,
   
   and gradually remove hard-coded legacy identifiers (such as sepa) by introducing a more consistent, centralized model—potentially via a joined enum in streampipes-model that can still handle legacy values during migration.
   
   Before starting, I’d like to clarify a few points to ensure the refactoring goes in the right direction:
   
   Is the expectation to introduce one primary enum that becomes the single source of truth for processing element types?
   
   Should legacy identifiers be handled via explicit mapping methods (e.g., fromLegacyValue) to allow incremental replacement?
   
   Is there a preferred order or scope for refactoring (e.g., backend first, then UI), given the size of the change?
   
   Once this is clarified, I’m happy to propose a concrete refactoring plan and open an initial PR with incremental, reviewable changes.
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org