You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/07 17:33:08 UTC
[GitHub] [tvm] lhutton1 opened a new pull request, #13309: [TVMC] Global pass context for compile and tune
lhutton1 opened a new pull request, #13309:
URL: https://github.com/apache/tvm/pull/13309
Comes as a followup from conversations in #13216. By making the pass context a global value for both `compile` and `tune` commands, we can ensure the pass context is exactly as the user expected and also test components such as `convert_graph_layout` under a pass context suitable for testing (e.g. add instruments). With this change, it becomes the users responsibility to ensure the PassContext they select is suitable for the passes that will be run. By default, `opt_level` remains as 3 so current workflows that do not alter the pass context from the command line / TVMC Python API should not be affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ekalda commented on a diff in pull request #13309: [TVMC] Global pass context for compile and tune
Posted by GitBox <gi...@apache.org>.
ekalda commented on code in PR #13309:
URL: https://github.com/apache/tvm/pull/13309#discussion_r1016459236
##########
tests/python/driver/tvmc/conftest.py:
##########
@@ -284,3 +286,17 @@ def @main(%data : Tensor[(1, 3, 64, 64), uint8], %weight : Tensor[(3, 3, 5, 5),
with open(file_path, "w") as relay_text:
relay_text.write(RELAY_MODEL)
return file_path
+
+
+@pytest.fixture(scope="session")
+def relay_conv2d():
+ """
+ Simple conv2d Replay implementation.
Review Comment:
Nit:
```suggestion
Simple conv2d Relay implementation.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron merged pull request #13309: [TVMC] Global pass context for compile and tune
Posted by GitBox <gi...@apache.org>.
leandron merged PR #13309:
URL: https://github.com/apache/tvm/pull/13309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13309: [TVMC] Global pass context for compile and tune
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13309:
URL: https://github.com/apache/tvm/pull/13309#issuecomment-1305955155
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @Mousius, @gromero <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on pull request #13309: [TVMC] Global pass context for compile and tune
Posted by GitBox <gi...@apache.org>.
lhutton1 commented on PR #13309:
URL: https://github.com/apache/tvm/pull/13309#issuecomment-1305955423
also cc @leandron @ekalda
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #13309: [TVMC] Global pass context for compile and tune
Posted by GitBox <gi...@apache.org>.
leandron commented on PR #13309:
URL: https://github.com/apache/tvm/pull/13309#issuecomment-1310308913
Thanks @ekalda @lhutton1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org