You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/11/21 23:40:51 UTC
[kudu-CR] KUDU-2222. update scan delta compact-test: increase write timeout
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8628
to review the following change.
Change subject: KUDU-2222. update_scan_delta_compact-test: increase write timeout
......................................................................
KUDU-2222. update_scan_delta_compact-test: increase write timeout
In ASAN builds, the 5-second timeout on 1000-row batches was not sufficient to
prevent write timeouts.
With this, the test passed on dist-test 100/100[1], whereas previously it
failed 87/100[2].
[1] http://dist-test.cloudera.org/job?job_id=todd.1511306572.114498
[2] http://dist-test.cloudera.org/job?job_id=todd.1511304651.87727
Change-Id: Ic393579320b87e0f5cec494870441b8aa69db3b6
---
M src/kudu/integration-tests/update_scan_delta_compact-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/8628/1
--
To view, visit http://gerrit.cloudera.org:8080/8628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic393579320b87e0f5cec494870441b8aa69db3b6
Gerrit-Change-Number: 8628
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] KUDU-2222. update scan delta compact-test: increase write timeout
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8628 )
Change subject: KUDU-2222. update_scan_delta_compact-test: increase write timeout
......................................................................
KUDU-2222. update_scan_delta_compact-test: increase write timeout
In ASAN builds, the 5-second timeout on 1000-row batches was not sufficient to
prevent write timeouts.
With this, the test passed on dist-test 100/100[1], whereas previously it
failed 87/100[2].
[1] http://dist-test.cloudera.org/job?job_id=todd.1511306572.114498
[2] http://dist-test.cloudera.org/job?job_id=todd.1511304651.87727
Change-Id: Ic393579320b87e0f5cec494870441b8aa69db3b6
Reviewed-on: http://gerrit.cloudera.org:8080/8628
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/update_scan_delta_compact-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic393579320b87e0f5cec494870441b8aa69db3b6
Gerrit-Change-Number: 8628
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2222. update scan delta compact-test: increase write timeout
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8628 )
Change subject: KUDU-2222. update_scan_delta_compact-test: increase write timeout
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic393579320b87e0f5cec494870441b8aa69db3b6
Gerrit-Change-Number: 8628
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 22 Nov 2017 00:20:31 +0000
Gerrit-HasComments: No