You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/16 08:06:24 UTC

[GitHub] [spark] EnricoMi commented on pull request #36413: [SPARK-39074][CI] Fail on upload, not download of missing test files

EnricoMi commented on PR #36413:
URL: https://github.com/apache/spark/pull/36413#issuecomment-1157361682

   Yes, it looks like the scope of the `if` condition of the `build` jobs is broader than the logic in `dev/run-tests.py`. The individual `build` jobs test individual sets of modules (e.g. module `sql`). They should be skipped if none of these modules have changed.
   
   The `Check changes` job creates the `build` output, which covers modules of all `build` jobs and is used to skip all `build` jobs. The individual `build` jobs test far smaller sets of modules, so there may always be modules skipped by `dev/run-tests.py` though `build` is `true`.
   
   This looks like a bigger change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org