You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2017/03/11 00:10:27 UTC
Review Request 57524: Support setting the rootfs on Mesos Containers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57524/
-----------------------------------------------------------
Review request for Aurora, Mehrdad Nurolahzade and Stephan Erb.
Bugs: AURORA-1903
https://issues.apache.org/jira/browse/AURORA-1903
Repository: aurora
Description
-------
The mesos unified containerizer does not support absolute container path mounts if no rootfs is set. This allows operators to switch between our current behaviour (mounting images as a volume) and setting the rootfs. See AURORA-1903 for more detailed analysis.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java 4dac9757a65e144142d36ee921b85a02a5311fe5
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java 5c987fd051728486172c8afd34219e86d56f00d5
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java e1cd81e6fbd98f23046e6e775be268be4310c62a
src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 93cc34cf8393f969087cd0fd6f577228c00170e9
Diff: https://reviews.apache.org/r/57524/diff/1/
Testing
-------
Thanks,
Zameer Manji
Re: Review Request 57524: Support setting the rootfs on Mesos
Containers.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57524/#review168691
-----------------------------------------------------------
Ship it!
Master (a07b9ed) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 11, 2017, 12:10 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57524/
> -----------------------------------------------------------
>
> (Updated March 11, 2017, 12:10 a.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade and Stephan Erb.
>
>
> Bugs: AURORA-1903
> https://issues.apache.org/jira/browse/AURORA-1903
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The mesos unified containerizer does not support absolute container path mounts if no rootfs is set. This allows operators to switch between our current behaviour (mounting images as a volume) and setting the rootfs. See AURORA-1903 for more detailed analysis.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java 4dac9757a65e144142d36ee921b85a02a5311fe5
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java 5c987fd051728486172c8afd34219e86d56f00d5
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
> src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java e1cd81e6fbd98f23046e6e775be268be4310c62a
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 93cc34cf8393f969087cd0fd6f577228c00170e9
>
>
> Diff: https://reviews.apache.org/r/57524/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 57524: Support setting the rootfs on Mesos
Containers.
Posted by Mehrdad Nurolahzade <me...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57524/#review168690
-----------------------------------------------------------
I would recommend adding @santhk to this review.
He's been doing some internal development in this area for us and has more context than I do.
- Mehrdad Nurolahzade
On March 10, 2017, 4:10 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57524/
> -----------------------------------------------------------
>
> (Updated March 10, 2017, 4:10 p.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade and Stephan Erb.
>
>
> Bugs: AURORA-1903
> https://issues.apache.org/jira/browse/AURORA-1903
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The mesos unified containerizer does not support absolute container path mounts if no rootfs is set. This allows operators to switch between our current behaviour (mounting images as a volume) and setting the rootfs. See AURORA-1903 for more detailed analysis.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java 4dac9757a65e144142d36ee921b85a02a5311fe5
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java 5c987fd051728486172c8afd34219e86d56f00d5
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac
> src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java e1cd81e6fbd98f23046e6e775be268be4310c62a
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 93cc34cf8393f969087cd0fd6f577228c00170e9
>
>
> Diff: https://reviews.apache.org/r/57524/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>