You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/15 17:36:28 UTC
[GitHub] [airflow] potiuk opened a new pull request #10345: Too much was happening in this pre-commit script
potiuk opened a new pull request #10345:
URL: https://github.com/apache/airflow/pull/10345
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #10345: Too much was happening in this pre-commit script
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10345:
URL: https://github.com/apache/airflow/pull/10345
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #10345: Too much was happening in this pre-commit script
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #10345:
URL: https://github.com/apache/airflow/pull/10345#discussion_r471017439
##########
File path: scripts/ci/pre_commit/pre_commit_check_integrations.sh
##########
@@ -16,14 +16,11 @@
# specific language governing permissions and limitations
# under the License.
set -euo pipefail
-
-PRE_COMMIT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
-AIRFLOW_SOURCES=$(cd "${PRE_COMMIT_DIR}/../../../" && pwd);
-cd "${AIRFLOW_SOURCES}" || exit 1
-
# shellcheck source=scripts/ci/libraries/_script_init.sh
. "$( dirname "${BASH_SOURCE[0]}" )/../libraries/_script_init.sh"
+cd "${AIRFLOW_SOURCES}" || exit 1
Review comment:
Is these variables defined in one of the file we source above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #10345: Too much was happening in this pre-commit script
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #10345:
URL: https://github.com/apache/airflow/pull/10345#discussion_r471031906
##########
File path: scripts/ci/pre_commit/pre_commit_check_integrations.sh
##########
@@ -16,14 +16,11 @@
# specific language governing permissions and limitations
# under the License.
set -euo pipefail
-
-PRE_COMMIT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
-AIRFLOW_SOURCES=$(cd "${PRE_COMMIT_DIR}/../../../" && pwd);
-cd "${AIRFLOW_SOURCES}" || exit 1
-
# shellcheck source=scripts/ci/libraries/_script_init.sh
. "$( dirname "${BASH_SOURCE[0]}" )/../libraries/_script_init.sh"
+cd "${AIRFLOW_SOURCES}" || exit 1
Review comment:
Yep
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10345: Too much was happening in this pre-commit script
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10345:
URL: https://github.com/apache/airflow/pull/10345#issuecomment-675554393
@kaxil :) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org