[jira] [Commented] (CASSANDRA-5582) Replace CustomHsHaServer with better optimized solution based on LMAX Disruptor

["Pavel Yaskevich (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-5582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13662383#comment-13662383 ] 

Pavel Yaskevich commented on CASSANDRA-5582:
--------------------------------------------

[~tjake] That's the idea about destiny of my server, I wasn't sure that Thrift will accept it with that dependency right away so I made it a separate project.

According to "new HsHa", as I already said, the part that actually handles established connections didn't change a bit - https://github.com/apache/thrift/blob/0.9.x/lib/java/src/org/apache/thrift/server/TThreadedSelectorServer.java in SelectorThread they still do "processInterestChanges". The only improvement I see (questionable under considerable load) is that server would be able to "accept" connections faster but "dispatch" part (when channel is actually registered with selector) still adds fair amount of contention. 
                
> Replace CustomHsHaServer with better optimized solution based on LMAX Disruptor
> -------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-5582
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5582
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: API, Core
>            Reporter: Pavel Yaskevich
>            Assignee: Pavel Yaskevich
>             Fix For: 2.0
>
>         Attachments: CASSANDRA-5582.patch, disruptor-3.0.0.beta3.jar, disruptor-thrift-0.1-SNAPSHOT.jar, Pavel's Patch.rtf
>
>
> I have been working on https://github.com/xedin/disruptor_thrift_server and consider it as stable and performant enough for integration with Cassandra. 
> Proposed replacement can work in both on/off Heap modes (depending if JNA is available) and doesn't blindly reallocate things, which allows to resolve CASSANDRA-4265 as "Won't Fix".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira