You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@struts.apache.org by Roberto Nunnari <ro...@supsi.ch> on 2009/04/07 20:10:06 UTC
validation
Hi guys.
I'm trying to use declarative xml validation but I'm having trouble.
This is the scenario:
- struts 2.0.11
- struts configuration with action name="*-*"
- ModelDriven actions
do the above scenario permit the use of xml validation?
Thank you.
Robi
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: validation
Posted by Roberto Nunnari <ro...@supsi.ch>.
yes.. I'd rather use declarative validation in xml, but if I cannot
get it to work, I'll do it on the client side..
Robi
Lukasz Lenart ha scritto:
> 2009/4/8 Mileidys Gonzalez Prieto <mi...@i-frontier.net>:
>> Im using this piece on code on my jsp
>>
>> <html:javascript formName="/submitCraft" dynamicJavascript="true"
>> staticJavascript="false" />
>
> Yeah, but the topic is about the problems with validation in Struts2
> not in Struts1 as you're presenting.
>
>
> Regards
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: validation
Posted by Lukasz Lenart <lu...@googlemail.com>.
2009/4/8 Mileidys Gonzalez Prieto <mi...@i-frontier.net>:
> Im using this piece on code on my jsp
>
> <html:javascript formName="/submitCraft" dynamicJavascript="true"
> staticJavascript="false" />
Yeah, but the topic is about the problems with validation in Struts2
not in Struts1 as you're presenting.
Regards
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: validation
Posted by Mileidys Gonzalez Prieto <mi...@i-frontier.net>.
Im using this piece on code on my jsp
<html:javascript formName="/submitCraft" dynamicJavascript="true"
staticJavascript="false" />
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: validation
Posted by Roberto Nunnari <ro...@supsi.ch>.
Wes, here you can find my files:
http://web.dti.supsi.ch/~nunnari/s2/
Robi
Wes Wannemacher ha scritto:
> On Wednesday 08 April 2009 10:48:34 Roberto Nunnari wrote:
> [snip]
>> I start to think there is something wrong with my environment..
>>
>> But.. are you guys sure that xml validation works when
>> implementing ModelDriven?
>>
>
> Yes, I am sure :) I've used it plenty.
>
> I was starting to think that there is something wrong with your setup the very
> minute I began reading that line. Can you post more details about your
> setup... Validation is controlled by an interceptor, so I would wonder if the
> interceptor is even firing at this point.
>
> -Wes
>
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: validation
Posted by Wes Wannemacher <we...@wantii.com>.
On Wednesday 08 April 2009 10:48:34 Roberto Nunnari wrote:
[snip]
>
> I start to think there is something wrong with my environment..
>
> But.. are you guys sure that xml validation works when
> implementing ModelDriven?
>
Yes, I am sure :) I've used it plenty.
I was starting to think that there is something wrong with your setup the very
minute I began reading that line. Can you post more details about your
setup... Validation is controlled by an interceptor, so I would wonder if the
interceptor is even firing at this point.
-Wes
--
Wes Wannemacher
Author - Struts 2 In Practice
Includes coverage of Struts 2.1, Spring, JPA, JQuery, Sitemesh and more
http://www.manning.com/wannemacher
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: validation
Posted by Roberto Nunnari <ro...@supsi.ch>.
Roberto Nunnari ha scritto:
>
> but for this validation doesn't work:
> package namespace: /admin2
> s2 action name: Item_update
> method name: update
> URI: /myapp/admin2/Item_update.action
> classname: ItemAction
> xml-valid: ItemAction-update-validation.xml
>
if I rename ItemAction-update-validation.xml to ItemAction-validation.xml
then everythig works.. it was just my environment.. probably those two
files I told you before in WEB-INF/
Also, I suppose that the alias the doc referes to about validation,
means action name, and not the method name.
Thank you all guys!
Robi
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: validation
Posted by Roberto Nunnari <ro...@supsi.ch>.
Ok. Something started to work.
Not sure though what the problem was.. maybe a couple of
validation files I had left around in WEB-INF/
Now I can validate even my ModelDriven actions by using
ClassName-methodName-validation.xml
so now I have:
package namespace: /admin/Item
s2 action name: update
method name: update
URI: /myapp/admin/Item/update.action
classname: ItemAction
xml-valid: ItemAction-update-validation.xml
but for this validation doesn't work:
package namespace: /admin2
s2 action name: Item_update
method name: update
URI: /myapp/admin2/Item_update.action
classname: ItemAction
xml-valid: ItemAction-update-validation.xml
package configuration (interceptor stack) is the same..
Any hints?
Thank you all guys!
Ciao.
Robi
Roberto Nunnari ha scritto:
> Hi Wes.
>
>
> Wes Wannemacher ha scritto:
>> I don't think you need the method name in validation file's filename.
>> I would try renaming the file to Item_update-validation.xml.
>
> Didn't help. I even tried to make a new package /admin/Item
> and use action names as update, view and edit.. naturally
> I renamed the validation file to update-validator.xml
> but didn't change anything.
>
>
>>
>> If your intention is to only validate when the method 'update' is
>> being called, you might have to use the Validation annotations rather
>> than the XML file. Remember though that there are a certain set of
>> results ignored by the validation interceptor by default (such as the
>> "input" result).
>
> I tried Annotations yesterday but didn't help neither.
>
> I start to think there is something wrong with my environment..
>
> But.. are you guys sure that xml validation works when
> implementing ModelDriven?
>
> Thanks
> Robi
>
>
>>
>> -Wes
>>
>> On Wednesday 08 April 2009 09:15:11 Roberto Nunnari wrote:
>>> Humm.. I don't know.. I tried with
>>>
>>> view:
>>> <s:form method="post" action="Item_update" namespace="/admin">
>>>
>>> struts.xml:
>>> <action name="Item_update" method="update"
>>> class="ch.nunnisoft.myecommerce.actions.admin.ItemAction">
>>> <result type="redirect-action">
>>> <param name="actionName">Item-view?id=${id}</param>
>>> </result>
>>> <result name="input" type="tiles">adminItemEdit</result>
>>> </action>
>>>
>>> and renamed validator xml file to:
>>> Item_update-update-validation.xml
>>>
>>> but still.. it doesn't check anything..
>>>
>>> Any more hints?
>>>
>>> Robi
>>>
>>> Lukasz Lenart ha scritto:
>>>> 2009/4/8 Roberto Nunnari <ro...@supsi.ch>:
>>>>> <action name="Item-update" method="update"
>>>> Action name is:
>>>> Item-update
>>>>
>>>> method name is:
>>>> update
>>>>
>>>> so then, validation file should be?
>>>> Item-update-update-validation.xml
>>>>
>>>>> and here's my Item-update-validation.xml file that I put in the same
>>>>> folder
>>>> In theory this should work for whole action Item-update, but I think
>>>> the problem is that double dash ;-)
>>>>
>>>> Change naming convention for your actions, use namespace instead names
>>>> like Item-update or use underscore
>>>>
>>>>
>>>> Regards
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: user-help@struts.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> For additional commands, e-mail: user-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: validation
Posted by Roberto Nunnari <ro...@supsi.ch>.
Hi Wes.
Wes Wannemacher ha scritto:
> I don't think you need the method name in validation file's filename. I would
> try renaming the file to Item_update-validation.xml.
Didn't help. I even tried to make a new package /admin/Item
and use action names as update, view and edit.. naturally
I renamed the validation file to update-validator.xml
but didn't change anything.
>
> If your intention is to only validate when the method 'update' is being
> called, you might have to use the Validation annotations rather than the XML
> file. Remember though that there are a certain set of results ignored by the
> validation interceptor by default (such as the "input" result).
I tried Annotations yesterday but didn't help neither.
I start to think there is something wrong with my environment..
But.. are you guys sure that xml validation works when
implementing ModelDriven?
Thanks
Robi
>
> -Wes
>
> On Wednesday 08 April 2009 09:15:11 Roberto Nunnari wrote:
>> Humm.. I don't know.. I tried with
>>
>> view:
>> <s:form method="post" action="Item_update" namespace="/admin">
>>
>> struts.xml:
>> <action name="Item_update" method="update"
>> class="ch.nunnisoft.myecommerce.actions.admin.ItemAction">
>> <result type="redirect-action">
>> <param name="actionName">Item-view?id=${id}</param>
>> </result>
>> <result name="input" type="tiles">adminItemEdit</result>
>> </action>
>>
>> and renamed validator xml file to:
>> Item_update-update-validation.xml
>>
>> but still.. it doesn't check anything..
>>
>> Any more hints?
>>
>> Robi
>>
>> Lukasz Lenart ha scritto:
>>> 2009/4/8 Roberto Nunnari <ro...@supsi.ch>:
>>>> <action name="Item-update" method="update"
>>> Action name is:
>>> Item-update
>>>
>>> method name is:
>>> update
>>>
>>> so then, validation file should be?
>>> Item-update-update-validation.xml
>>>
>>>> and here's my Item-update-validation.xml file that I put in the same
>>>> folder
>>> In theory this should work for whole action Item-update, but I think
>>> the problem is that double dash ;-)
>>>
>>> Change naming convention for your actions, use namespace instead names
>>> like Item-update or use underscore
>>>
>>>
>>> Regards
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>> For additional commands, e-mail: user-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: validation
Posted by Wes Wannemacher <we...@wantii.com>.
I don't think you need the method name in validation file's filename. I would
try renaming the file to Item_update-validation.xml.
If your intention is to only validate when the method 'update' is being
called, you might have to use the Validation annotations rather than the XML
file. Remember though that there are a certain set of results ignored by the
validation interceptor by default (such as the "input" result).
-Wes
On Wednesday 08 April 2009 09:15:11 Roberto Nunnari wrote:
> Humm.. I don't know.. I tried with
>
> view:
> <s:form method="post" action="Item_update" namespace="/admin">
>
> struts.xml:
> <action name="Item_update" method="update"
> class="ch.nunnisoft.myecommerce.actions.admin.ItemAction">
> <result type="redirect-action">
> <param name="actionName">Item-view?id=${id}</param>
> </result>
> <result name="input" type="tiles">adminItemEdit</result>
> </action>
>
> and renamed validator xml file to:
> Item_update-update-validation.xml
>
> but still.. it doesn't check anything..
>
> Any more hints?
>
> Robi
>
> Lukasz Lenart ha scritto:
> > 2009/4/8 Roberto Nunnari <ro...@supsi.ch>:
> >> <action name="Item-update" method="update"
> >
> > Action name is:
> > Item-update
> >
> > method name is:
> > update
> >
> > so then, validation file should be?
> > Item-update-update-validation.xml
> >
> >> and here's my Item-update-validation.xml file that I put in the same
> >> folder
> >
> > In theory this should work for whole action Item-update, but I think
> > the problem is that double dash ;-)
> >
> > Change naming convention for your actions, use namespace instead names
> > like Item-update or use underscore
> >
> >
> > Regards
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> For additional commands, e-mail: user-help@struts.apache.org
--
Wes Wannemacher
Author - Struts 2 In Practice
Includes coverage of Struts 2.1, Spring, JPA, JQuery, Sitemesh and more
http://www.manning.com/wannemacher
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: validation
Posted by Roberto Nunnari <ro...@supsi.ch>.
Yep. I tried that and doesn't help neither.
I also tried the underscore version but nothing changed.
Any more hints?
Robi
Lukasz Lenart ha scritto:
> 2009/4/8 Roberto Nunnari <ro...@supsi.ch>:
>> <action name="Item-update" method="update"
>
> Action name is:
> Item-update
>
> method name is:
> update
>
> so then, validation file should be?
> Item-update-update-validation.xml
>
>> and here's my Item-update-validation.xml file that I put in the same folder
>
> In theory this should work for whole action Item-update, but I think
> the problem is that double dash ;-)
>
> Change naming convention for your actions, use namespace instead names
> like Item-update or use underscore
>
>
> Regards
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: validation
Posted by Roberto Nunnari <ro...@supsi.ch>.
tried it: doesn't help.
Lukasz Lenart ha scritto:
> 2009/4/8 Roberto Nunnari <ro...@supsi.ch>:
>> Any more hints?
>
> Could you remove this from top of your validation file?
>
> <?xml version="1.0" encoding="UTF-8"?>
>
> <!--
> Document : ItemAction-validation.xml
> Created on : 24 marzo 2009, 20:40
> Author : nunnari
> Description:
> -->
>
>
> Pozdrawiam
--
Roberto Nunnari
Servizi Informatici SUPSI-DTI
SUPSI-DTI - Via Cantonale - 6928 Manno - Switzerland
email: mailto:roberto.nunnari@supsi.ch
tel: +41-58-6666561
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: validation
Posted by Lukasz Lenart <lu...@googlemail.com>.
2009/4/8 Roberto Nunnari <ro...@supsi.ch>:
> Any more hints?
Could you remove this from top of your validation file?
<?xml version="1.0" encoding="UTF-8"?>
<!--
Document : ItemAction-validation.xml
Created on : 24 marzo 2009, 20:40
Author : nunnari
Description:
-->
Pozdrawiam
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: validation
Posted by Roberto Nunnari <ro...@supsi.ch>.
Humm.. I don't know.. I tried with
view:
<s:form method="post" action="Item_update" namespace="/admin">
struts.xml:
<action name="Item_update" method="update"
class="ch.nunnisoft.myecommerce.actions.admin.ItemAction">
<result type="redirect-action">
<param name="actionName">Item-view?id=${id}</param>
</result>
<result name="input" type="tiles">adminItemEdit</result>
</action>
and renamed validator xml file to:
Item_update-update-validation.xml
but still.. it doesn't check anything..
Any more hints?
Robi
Lukasz Lenart ha scritto:
> 2009/4/8 Roberto Nunnari <ro...@supsi.ch>:
>> <action name="Item-update" method="update"
>
> Action name is:
> Item-update
>
> method name is:
> update
>
> so then, validation file should be?
> Item-update-update-validation.xml
>
>> and here's my Item-update-validation.xml file that I put in the same folder
>
> In theory this should work for whole action Item-update, but I think
> the problem is that double dash ;-)
>
> Change naming convention for your actions, use namespace instead names
> like Item-update or use underscore
>
>
> Regards
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: validation
Posted by Lukasz Lenart <lu...@googlemail.com>.
2009/4/8 Roberto Nunnari <ro...@supsi.ch>:
> <action name="Item-update" method="update"
Action name is:
Item-update
method name is:
update
so then, validation file should be?
Item-update-update-validation.xml
> and here's my Item-update-validation.xml file that I put in the same folder
In theory this should work for whole action Item-update, but I think
the problem is that double dash ;-)
Change naming convention for your actions, use namespace instead names
like Item-update or use underscore
Regards
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: validation
Posted by Roberto Nunnari <ro...@supsi.ch>.
Hi.
see my comments in context.
Lukasz Lenart ha scritto:
> 2009/4/7 Roberto Nunnari <ro...@supsi.ch>:
>> do the above scenario permit the use of xml validation?
>
> It shouldn't be a problem, did you double check that validations files
> were transferred to the server?
Yes. I checked and the xml file is there.
I even tried to put the action name without wildcards
(see below action Item-update)
in struts.xml, but it still doesn't work.
The action extends ActionSupport and implements ModelDriven, Preparable
here's my package from the struts.xml file:
*************************** start cut *************************
<package name="admin" extends="tiles-default" namespace="/admin">
<interceptors>
<interceptor name="HibernateOSIV" class="osivInterceptor"/>
<interceptor-stack name="robiStack">
<interceptor-ref name="exception"/>
<interceptor-ref name="alias"/>
<interceptor-ref name="servletConfig"/>
<interceptor-ref name="HibernateOSIV"/>
<interceptor-ref name="prepare"/>
<interceptor-ref name="i18n"/>
<interceptor-ref name="chain"/>
<interceptor-ref name="debugging"/>
<interceptor-ref name="profiling"/>
<interceptor-ref name="scopedModelDriven"/>
<interceptor-ref name="modelDriven"/>
<interceptor-ref name="fileUpload"/>
<interceptor-ref name="checkbox"/>
<interceptor-ref name="staticParams"/>
<interceptor-ref name="params">
<param name="excludeParams">dojo\..*</param>
</interceptor-ref>
<interceptor-ref name="conversionError"/>
<interceptor-ref name="validation">
<param
name="excludeMethods">input,back,cancel,browse</param>
</interceptor-ref>
<interceptor-ref name="workflow">
<param
name="excludeMethods">input,back,cancel,browse</param>
</interceptor-ref>
</interceptor-stack>
<interceptor-stack name="robiStackPrep">
<interceptor-ref name="exception"/>
<interceptor-ref name="alias"/>
<interceptor-ref name="params"/>
<interceptor-ref name="servletConfig"/>
<interceptor-ref name="HibernateOSIV"/>
<interceptor-ref name="prepare"/>
<interceptor-ref name="i18n"/>
<interceptor-ref name="chain"/>
<interceptor-ref name="modelDriven"/>
<interceptor-ref name="fileUpload"/>
<interceptor-ref name="checkbox"/>
<interceptor-ref name="staticParams"/>
<interceptor-ref name="params"/>
<interceptor-ref name="conversionError"/>
<interceptor-ref name="validation">
<param name="excludeMethods">input,back,cancel</param>
</interceptor-ref>
<interceptor-ref name="workflow">
<param name="excludeMethods">input,back,cancel</param>
</interceptor-ref>
</interceptor-stack>
</interceptors>
<default-interceptor-ref name="robiStackPrep"/>
<action name="listWantNewsletterEmails"
method="wantNewsletterEmails"
class="ch.nunnisoft.myecommerce.actions.admin.NewsletterAction">
<result type="tiles">adminWantNewsletterEmailList</result>
</action>
<action name="list*" method="{1}"
class="ch.nunnisoft.myecommerce.actions.admin.HomeAction">
<result type="tiles">admin{1}List</result>
</action>
<action name="*-createChoose" method="chooseType"
class="ch.nunnisoft.myecommerce.actions.admin.{1}Action">
<result type="tiles">admin{1}ChooseType</result>
</action>
<action name="Item-update" method="update"
class="ch.nunnisoft.myecommerce.actions.admin.ItemAction">
<result type="redirect-action">
<param name="actionName">Item-view?id=${id}</param>
</result>
<result name="input" type="tiles">adminItemEdit</result>
</action>
<action name="*-*" method="{2}"
class="ch.nunnisoft.myecommerce.actions.admin.{1}Action">
<!--
{1} puo' essere: search, searchForm, view, create, save,
addToCart, viewCart
-->
<result type="redirect-action">
<param name="actionName">{1}-view?id=${id}</param>
</result>
<result name="successA" type="redirect-action">
<param name="actionName">{1}-view?id=${id}</param>
</result>
<result name="successQ" type="redirect-action">
<param name="actionName">{1}-view?id=${id}</param>
</result>
<result name="successCT" type="redirect-action">
<param
name="actionName">Category-view?id=${categoryId}</param>
</result>
<result name="successIT" type="redirect-action">
<param name="actionName">Item-view?id=${itemId}</param>
</result>
<result name="successAT" type="redirect-action">
<param
name="actionName">Auction-view?id=${auctionId}</param>
</result>
<result name="listItem" type="redirect-action">
<param name="actionName">listItem</param>
</result>
<result name="home" type="redirect-action">
<param name="actionName">list{1}</param>
</result>
<result name="view" type="tiles">admin{1}View</result>
<result name="input" type="tiles">admin{1}Edit</result>
<result name="create" type="tiles">admin{1}New</result>
<result name="home" type="tiles">admin{1}List</result>
<result name="inputA" type="tiles">admin{1}AEdit</result>
<result name="inputQ" type="tiles">admin{1}QEdit</result>
<result name="createA" type="tiles">admin{1}ANew</result>
<result name="createQ" type="tiles">admin{1}QNew</result>
<result name="viewA" type="tiles">admin{1}AView</result>
<result name="viewQ" type="tiles">admin{1}QView</result>
</action>
</package>
*************************** end cut *************************
and here's my Item-update-validation.xml file that I put in the same
folder as the action ItemAction:
*************************** start cut *************************
<?xml version="1.0" encoding="UTF-8"?>
<!--
Document : ItemAction-validation.xml
Created on : 24 marzo 2009, 20:40
Author : nunnari
Description:
-->
<!DOCTYPE validators PUBLIC '-//OpenSymphony Group//XWork Validator
1.0.2//EN' 'http://www.opensymphony.com/xwork/xwork-validator-1.0.2.dtd'>
<validators>
<field name="itemNumber">
<field-validator type="requiredstring">
<message key="error.PleaseEnterAValidString"/>
</field-validator>
</field>
<field name="price.amount">
<field-validator type="required">
<message key="error.PleaseEnterAValidValue"/>
</field-validator>
<field-validator type="double">
<message key="error.PleaseEnterAValidPassword"/>
</field-validator>
</field>
</validators>
*************************** end cut *************************
Please somebody help. Thank you.
Robi
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: validation
Posted by Lukasz Lenart <lu...@googlemail.com>.
2009/4/7 Roberto Nunnari <ro...@supsi.ch>:
> do the above scenario permit the use of xml validation?
It shouldn't be a problem, did you double check that validations files
were transferred to the server?
Regards
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org