You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ly...@apache.org on 2023/01/06 01:13:21 UTC
[superset] branch lyndsi/fix-report-screenshot created (now 8b4cd90ac9)
This is an automated email from the ASF dual-hosted git repository.
lyndsi pushed a change to branch lyndsi/fix-report-screenshot
in repository https://gitbox.apache.org/repos/asf/superset.git
at 8b4cd90ac9 Remove filter bar from reports
This branch includes the following new commits:
new 8b4cd90ac9 Remove filter bar from reports
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[superset] 01/01: Remove filter bar from reports
Posted by ly...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
lyndsi pushed a commit to branch lyndsi/fix-report-screenshot
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 8b4cd90ac930f127f65515c2d81b05b0ce8b1467
Author: lyndsiWilliams <kc...@gmail.com>
AuthorDate: Thu Jan 5 19:09:39 2023 -0600
Remove filter bar from reports
---
.../DashboardBuilder/DashboardBuilder.tsx | 24 ++++++++++++----------
superset/utils/screenshots.py | 2 +-
2 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx b/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
index d2ce6a2f1a..2dc2f3c27c 100644
--- a/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
+++ b/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
@@ -452,17 +452,19 @@ const DashboardBuilder: FC<DashboardBuilderProps> = () => {
>
<StickyPanel ref={containerRef} width={filterBarWidth}>
<ErrorBoundary>
- <FilterBar
- focusedFilterId={focusedFilterId}
- orientation={FilterBarOrientation.VERTICAL}
- verticalConfig={{
- filtersOpen: dashboardFiltersOpen,
- toggleFiltersBar: toggleDashboardFiltersOpen,
- width: filterBarWidth,
- height: filterBarHeight,
- offset: filterBarOffset,
- }}
- />
+ {!isReport && (
+ <FilterBar
+ focusedFilterId={focusedFilterId}
+ orientation={FilterBarOrientation.VERTICAL}
+ verticalConfig={{
+ filtersOpen: dashboardFiltersOpen,
+ toggleFiltersBar: toggleDashboardFiltersOpen,
+ width: filterBarWidth,
+ height: filterBarHeight,
+ offset: filterBarOffset,
+ }}
+ />
+ )}
</ErrorBoundary>
</StickyPanel>
</FiltersPanel>
diff --git a/superset/utils/screenshots.py b/superset/utils/screenshots.py
index c81ede6dc1..741bc9ea5f 100644
--- a/superset/utils/screenshots.py
+++ b/superset/utils/screenshots.py
@@ -212,7 +212,7 @@ class ChartScreenshot(BaseScreenshot):
class DashboardScreenshot(BaseScreenshot):
thumbnail_type: str = "dashboard"
- element: str = "grid-container"
+ element: str = "standalone"
def __init__(
self,