You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/12/16 15:48:56 UTC

[GitHub] [commons-vfs] boris-petrov commented on pull request #150: Call `refresh` by default in `AbstractFileObject.onChange`

boris-petrov commented on pull request #150:
URL: https://github.com/apache/commons-vfs/pull/150#issuecomment-746511940


   @garydgregory - I spent a lot of time trying to figure what's going on. I give up. This test failure is definitely a bug in the `RamFileProvider` but it is difficult to fix. I changed a bunch of things and always something fails.
   
   If you have the time, I would suggest you look into this and try fixing it.
   
   Things that I saw which are not OK:
   
   1) `AbstractFileObject::injectType` is only overridden in `RamFileObject` which seems fishy. I would try to remove this method.
   
   1) `AbstractFileObject::endOutput` is a strange method. It is overridden only in `RamFileObject` which, again, is not nice.
   
   Check also #151. I fixed some more "bad" things in the code around this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org