You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/05/27 03:36:28 UTC
Re: Review Request 34692: Create widget wizard: Metric selection
shown for JournalNode component in non NN HA cluster
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34692/
-----------------------------------------------------------
(Updated May 27, 2015, 1:36 a.m.)
Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Summary (updated)
-----------------
Create widget wizard: Metric selection shown for JournalNode component in non NN HA cluster
Bugs: AMBARI-11407
https://issues.apache.org/jira/browse/AMBARI-11407
Repository: ambari
Description
-------
Metric selection should not show option for a service component if none of its host component are yet created in the cluster.
Diffs
-----
ambari-web/app/mixins/common/widgets/widget_mixin.js 9e20cf4
ambari-web/app/models/service/hdfs.js d00479f
ambari-web/app/views/main/service/widgets/create/expression_view.js 9900915
Diff: https://reviews.apache.org/r/34692/diff/
Testing
-------
Tested the patch in NameNode HA and non HA mode.
verified that all unit tests passes.
Thanks,
Jaimin Jetly
Re: Review Request 34692: Create widget wizard: Metric selection
shown for JournalNode component in non NN HA cluster
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34692/#review85312
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On May 27, 2015, 1:36 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34692/
> -----------------------------------------------------------
>
> (Updated May 27, 2015, 1:36 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-11407
> https://issues.apache.org/jira/browse/AMBARI-11407
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Metric selection should not show option for a service component if none of its host component are yet created in the cluster.
>
>
> Diffs
> -----
>
> ambari-web/app/mixins/common/widgets/widget_mixin.js 9e20cf4
> ambari-web/app/models/service/hdfs.js d00479f
> ambari-web/app/views/main/service/widgets/create/expression_view.js 9900915
>
> Diff: https://reviews.apache.org/r/34692/diff/
>
>
> Testing
> -------
>
> Tested the patch in NameNode HA and non HA mode.
> verified that all unit tests passes.
>
>
> Thanks,
>
> Jaimin Jetly
>
>