You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ns...@apache.org on 2011/10/11 04:13:25 UTC

svn commit: r1181492 - /hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java

Author: nspiegelberg
Date: Tue Oct 11 02:13:24 2011
New Revision: 1181492

URL: http://svn.apache.org/viewvc?rev=1181492&view=rev
Log:
fix fsWriteSize metric

Summary:
fsWriteSize (size of append to HLog) metric wasn't getting recorded correctly.

Test Plan:
Tested this on my dev cluster.

Differential Revision: 217250
Reviewed By: kranganathan
Reviewers: kranganathan
CC: kannan, kranganathan, hbase@lists
Revert Plan:
OK

Modified:
    hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java

Modified: hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java?rev=1181492&r1=1181491&r2=1181492&view=diff
==============================================================================
--- hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java (original)
+++ hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java Tue Oct 11 02:13:24 2011
@@ -263,6 +263,7 @@ public class RegionServerMetrics impleme
       // push the result
       this.fsReadLatency.pushMetric(this.metricsRecord);
       this.fsWriteLatency.pushMetric(this.metricsRecord);
+      this.fsWriteSize.pushMetric(this.metricsRecord);
       this.fsSyncLatency.pushMetric(this.metricsRecord);
       this.fsGroupSyncLatency.pushMetric(this.metricsRecord);
       this.compactionTime.pushMetric(this.metricsRecord);
@@ -289,6 +290,7 @@ public class RegionServerMetrics impleme
     this.atomicIncrementTime.resetMinMax();
     this.fsReadLatency.resetMinMax();
     this.fsWriteLatency.resetMinMax();
+    this.fsWriteSize.resetMinMax();
     this.fsSyncLatency.resetMinMax();
     this.fsGroupSyncLatency.resetMinMax();
   }