You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org> on 2022/06/16 09:29:35 UTC

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Gergely Fürnstáhl has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18627


Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................

IMPALA-11358: Fixed Kudu table's missing comment

If Kudu-HMS integration is enabled, Kudu creates the table in HMS too,
which was missing the comment field. Added the code to forward the
comment field to Kudu during creation.

Testing:

Added a test to verify the comment is present when the intergration is
enabled.
Reenabled several kudu tests as IMPALA-8751 (and follow ups) fixed the
hive3 notification incompatibility.

Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
---
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M tests/common/skip.py
M tests/custom_cluster/test_kudu.py
3 files changed, 6 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/18627/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 2
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................


Patch Set 9:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8252/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 9
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jun 2022 14:47:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10786/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 5
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Jun 2022 15:24:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org>.
Gergely Fürnstáhl has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................

IMPALA-11358: Fixed Kudu table's missing comment

If Kudu-HMS integration is enabled, Kudu creates the table in HMS too,
which was missing the comment field. Added the code to forward the
comment field to Kudu during creation.

Testing:

Added a test to verify the comment is present when the intergration is
enabled.
Reenabled several kudu tests as IMPALA-8751 (and follow ups) fixed the
hive3 notification incompatibility.

Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
---
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M tests/common/skip.py
M tests/custom_cluster/test_kudu.py
3 files changed, 7 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/18627/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 4
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................


Patch Set 9: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 9
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jun 2022 14:47:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8249/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 8
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jun 2022 09:26:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................


Patch Set 9: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 9
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jun 2022 19:38:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10781/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 4
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Jun 2022 09:55:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................

IMPALA-11358: Fixed Kudu table's missing comment

If Kudu-HMS integration is enabled, Kudu creates the table in HMS too,
which was missing the comment field. Added the code to forward the
comment field to Kudu during creation.

Testing:

Added a test to verify the comment is present when the intergration is
enabled.
Reenabled several kudu tests as IMPALA-8751 (and follow ups) fixed the
hive3 notification incompatibility.

Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Reviewed-on: http://gerrit.cloudera.org:8080/18627
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M tests/common/skip.py
M tests/custom_cluster/test_kudu.py
3 files changed, 12 insertions(+), 14 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 10
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org>.
Gergely Fürnstáhl has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................

IMPALA-11358: Fixed Kudu table's missing comment

If Kudu-HMS integration is enabled, Kudu creates the table in HMS too,
which was missing the comment field. Added the code to forward the
comment field to Kudu during creation.

Testing:

Added a test to verify the comment is present when the intergration is
enabled.
Reenabled several kudu tests as IMPALA-8751 (and follow ups) fixed the
hive3 notification incompatibility.

Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
---
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M tests/common/skip.py
M tests/custom_cluster/test_kudu.py
3 files changed, 9 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/18627/5
-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 5
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10795/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 7
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 11:55:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org>.
Gergely Fürnstáhl has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................

IMPALA-11358: Fixed Kudu table's missing comment

If Kudu-HMS integration is enabled, Kudu creates the table in HMS too,
which was missing the comment field. Added the code to forward the
comment field to Kudu during creation.

Testing:

Added a test to verify the comment is present when the intergration is
enabled.
Reenabled several kudu tests as IMPALA-8751 (and follow ups) fixed the
hive3 notification incompatibility.

Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
---
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M tests/common/skip.py
M tests/custom_cluster/test_kudu.py
3 files changed, 12 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/18627/7
-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 7
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org>.
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18627/5/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/18627/5/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java@259
PS5, Line 259:     if (params.getComment() != null) tableOpts.setComment(params.getComment());
             : 
> nit: in Impala we add braces if we have to break the line after if
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 6
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 10:40:42 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 4
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Jun 2022 11:04:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................


Patch Set 8: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 8
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jun 2022 09:26:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10780/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 2
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Jun 2022 09:49:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18627/5/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/18627/5/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java@259
PS5, Line 259:     if(params.getComment() != null)
             :       tableOpts.setComment(params.getComment());
nit: in Impala we add braces if we have to break the line after if



-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 5
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 06:21:20 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10794/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 6
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 11:00:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18627/6/tests/custom_cluster/test_kudu.py
File tests/custom_cluster/test_kudu.py:

http://gerrit.cloudera.org:8080/#/c/18627/6/tests/custom_cluster/test_kudu.py@217
PS6, Line 217: cdw-master
Maybe use 'newer hive' rather than 'cdw-master hive', as this cdw-master doesn't mean too much upstream.



-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 6
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Jun 2022 11:25:48 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8241/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 4
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Jun 2022 11:38:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8241/


-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 4
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Jun 2022 13:23:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18627/2/tests/custom_cluster/test_kudu.py
File tests/custom_cluster/test_kudu.py:

http://gerrit.cloudera.org:8080/#/c/18627/2/tests/custom_cluster/test_kudu.py@209
PS2, Line 209: e
flake8: E501 line too long (102 > 90 characters)



-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 2
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Jun 2022 09:30:30 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org>.
Gergely Fürnstáhl has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................

IMPALA-11358: Fixed Kudu table's missing comment

If Kudu-HMS integration is enabled, Kudu creates the table in HMS too,
which was missing the comment field. Added the code to forward the
comment field to Kudu during creation.

Testing:

Added a test to verify the comment is present when the intergration is
enabled.
Reenabled several kudu tests as IMPALA-8751 (and follow ups) fixed the
hive3 notification incompatibility.

Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
---
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M tests/common/skip.py
M tests/custom_cluster/test_kudu.py
3 files changed, 12 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/18627/6
-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 6
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................


Patch Set 7: Code-Review+2

LGTM! Thanks for fixing this.


-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 7
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jun 2022 09:25:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11358: Fixed Kudu table's missing comment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18627 )

Change subject: IMPALA-11358: Fixed Kudu table's missing comment
......................................................................


Patch Set 8: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8249/


-- 
To view, visit http://gerrit.cloudera.org:8080/18627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Gerrit-Change-Number: 18627
Gerrit-PatchSet: 8
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jun 2022 14:15:34 +0000
Gerrit-HasComments: No