You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/10 09:14:16 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6816: arch/arm: Remove the critical section protection in up_invalidate_dcache_all

xiaoxiang781216 commented on code in PR #6816:
URL: https://github.com/apache/incubator-nuttx/pull/6816#discussion_r942217804


##########
arch/arm/src/armv7-r/arm_cache.c:
##########
@@ -81,14 +81,8 @@ void up_invalidate_dcache(uintptr_t start, uintptr_t end)
 
 void up_invalidate_dcache_all(void)
 {
-#ifdef CONFIG_ARCH_L2CACHE

Review Comment:
   Because if CONFIG_ARCH_L2CACHE isn't defined, all functions become empty macros:
   https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/armv7-a/l2cc.h#L232-L240



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org