You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by liuyu000 <gi...@git.apache.org> on 2018/08/07 11:12:49 UTC
[GitHub] trafodion pull request #1683: [TRAFODION-3178] Correct Syntax Descriptions o...
GitHub user liuyu000 opened a pull request:
https://github.com/apache/trafodion/pull/1683
[TRAFODION-3178] Correct Syntax Descriptions of *CREATE PROCEDURE Statement* and Fix Typos in *Trafodion SQL Reference Manual*
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liuyu000/trafodion CreateProcedureStatement_JavaDataType
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1683.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1683
----
commit 3a925fe7295f39a663a53e75075919dcb50a1d86
Author: liu.yu <qw...@...>
Date: 2018-08-07T11:08:23Z
[TRAFODION-3178] Correct Syntax Descriptions of *CREATE PROCEDURE Statement* and Fix Typos in *Trafodion SQL Reference Manual*
commit b928e513ec10f0aebf6d0167198337fe7a16bcfc
Author: liu.yu <qw...@...>
Date: 2018-08-07T11:11:31Z
Update 1
----
---
[GitHub] trafodion pull request #1683: [TRAFODION-3178] Correct Syntax Descriptions o...
Posted by liuyu000 <gi...@git.apache.org>.
Github user liuyu000 commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1683#discussion_r208434256
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_clauses.adoc ---
@@ -1053,8 +1053,7 @@ expressions in each item must be the same as the number of value columns
in the column list.
+
In the example TRANSPOSE A,B,C AS V, the items are A,B, and C, and the
-value column is V. This form can be thought of as a shorter way of writing TRANSPOSE
-(A),(B),(C) AS (V).
+value column is V. This form can be thought of as a shorter way of writing TRANSPOSE (A),(B),\(C) AS (V).
--- End diff --
Yes, the slash is an escape, (C) is rendered as © 😁
---
[GitHub] trafodion pull request #1683: [TRAFODION-3178] Correct Syntax Descriptions o...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1683#discussion_r208397031
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc ---
@@ -31,20 +31,27 @@ and expressions that you can use in {project-name} SQL statements. The
functions and expressions are categorized according to their
functionality.
-[[standard_normalization]]
-== Standard Normalization
+[[categories]]
+== Categories
-For datetime functions, the definition of standard normalization is: If
-the ending day of the resulting date is invalid, the day will be rounded
-DOWN to the last day of the result month.
+Use these types of functions within an SQL value expression:
-== Aggregate (Set) Functions
+** Aggregate (Set) Functions
--- End diff --
Do you want to include LOB Functions and Encryption Functions in this list?
---
[GitHub] trafodion pull request #1683: [TRAFODION-3178] Correct Syntax Descriptions o...
Posted by liuyu000 <gi...@git.apache.org>.
Github user liuyu000 commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1683#discussion_r208434649
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc ---
@@ -31,20 +31,27 @@ and expressions that you can use in {project-name} SQL statements. The
functions and expressions are categorized according to their
functionality.
-[[standard_normalization]]
-== Standard Normalization
+[[categories]]
+== Categories
-For datetime functions, the definition of standard normalization is: If
-the ending day of the resulting date is invalid, the day will be rounded
-DOWN to the last day of the result month.
+Use these types of functions within an SQL value expression:
-== Aggregate (Set) Functions
+** Aggregate (Set) Functions
--- End diff --
@DaveBirdsall Thanks, I've added 😁
---
[GitHub] trafodion pull request #1683: [TRAFODION-3178] Correct Syntax Descriptions o...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1683#discussion_r208396395
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_clauses.adoc ---
@@ -1053,8 +1053,7 @@ expressions in each item must be the same as the number of value columns
in the column list.
+
In the example TRANSPOSE A,B,C AS V, the items are A,B, and C, and the
-value column is V. This form can be thought of as a shorter way of writing TRANSPOSE
-(A),(B),(C) AS (V).
+value column is V. This form can be thought of as a shorter way of writing TRANSPOSE (A),(B),\(C) AS (V).
--- End diff --
Not sure why the slash is before "(C)"; I don't think it is correct. Or is the slash an escape? Maybe "(C)" is interpreted as the copyright symbol by the rendering software?
---
[GitHub] trafodion pull request #1683: [TRAFODION-3178] Correct Syntax Descriptions o...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafodion/pull/1683
---