[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3009: Check overflow when casting integer to decimal

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #3009:
URL: https://github.com/apache/arrow-rs/pull/3009#discussion_r1013554960


##########
arrow-array/src/types.rs:
##########
@@ -521,6 +524,10 @@ impl DecimalType for Decimal128Type {
         format_decimal_str(&value.to_string(), precision as usize, scale as usize)
     }
 
+    fn format_decimal_type(precision: u8, scale: u8) -> String {

Review Comment:
   The way we have handled this in other places is an associated const PREFIX



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org