You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by sr...@apache.org on 2021/10/27 11:59:32 UTC
[plc4x] branch feature/mspec-ng updated: fix(plc4j/codgen): fix
bacnet spec
This is an automated email from the ASF dual-hosted git repository.
sruehl pushed a commit to branch feature/mspec-ng
in repository https://gitbox.apache.org/repos/asf/plc4x.git
The following commit(s) were added to refs/heads/feature/mspec-ng by this push:
new 8a16e46 fix(plc4j/codgen): fix bacnet spec
8a16e46 is described below
commit 8a16e461a7e9dddc7b949b872cf670cc1949aef1
Author: Sebastian Rühl <sr...@apache.org>
AuthorDate: Wed Oct 27 13:59:25 2021 +0200
fix(plc4j/codgen): fix bacnet spec
---
.../src/main/resources/protocols/bacnetip/bacnetip.mspec | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/protocols/bacnetip/src/main/resources/protocols/bacnetip/bacnetip.mspec b/protocols/bacnetip/src/main/resources/protocols/bacnetip/bacnetip.mspec
index 5115306..5d44634 100644
--- a/protocols/bacnetip/src/main/resources/protocols/bacnetip/bacnetip.mspec
+++ b/protocols/bacnetip/src/main/resources/protocols/bacnetip/bacnetip.mspec
@@ -353,7 +353,7 @@
['DOUBLE' BACnetComplexTagDouble(uint 3 'lengthValueType', uint 8 'extLength')
[simple float 64 'value']
]
- ['OCTET_STRING' BACnetComplexTagOctetString(uint 32 'actualLength')
+ ['OCTET_STRING' BACnetComplexTagOctetString
// TODO: The reader expects int but uint32 get's mapped to long so even uint32 would easily overflow...
[virtual uint 16 'actualLengthInBit' 'actualLength * 8']
[simple vstring 'actualLengthInBit' 'theString' encoding='ASCII']
@@ -554,27 +554,27 @@
]
['APPLICATION_TAGS','0x1' BACnetTagApplicationBoolean
]
- ['APPLICATION_TAGS','0x2' BACnetTagApplicationUnsignedInteger [uint 3 'lengthValueType', uint 8 'extLength']
+ ['APPLICATION_TAGS','0x2' BACnetTagApplicationUnsignedInteger (uint 3 'lengthValueType', uint 8 'extLength')
[array int 8 'data' length '(lengthValueType == 5) ? extLength : lengthValueType']
]
- ['APPLICATION_TAGS','0x3' BACnetTagApplicationSignedInteger [uint 3 'lengthValueType', uint 8 'extLength']
+ ['APPLICATION_TAGS','0x3' BACnetTagApplicationSignedInteger (uint 3 'lengthValueType', uint 8 'extLength')
[array int 8 'data' length '(lengthValueType == 5) ? extLength : lengthValueType']
]
- ['APPLICATION_TAGS','0x4' BACnetTagApplicationReal [uint 3 'lengthValueType', uint 8 'extLength']
+ ['APPLICATION_TAGS','0x4' BACnetTagApplicationReal (uint 3 'lengthValueType', uint 8 'extLength')
[simple float 32 'value']
]
- ['APPLICATION_TAGS','0x5' BACnetTagApplicationDouble [uint 3 'lengthValueType', uint 8 'extLength']
+ ['APPLICATION_TAGS','0x5' BACnetTagApplicationDouble (uint 3 'lengthValueType', uint 8 'extLength')
[simple float 64 'value']
]
['APPLICATION_TAGS','0x6' BACnetTagApplicationOctetString
]
['APPLICATION_TAGS','0x7' BACnetTagApplicationCharacterString
]
- ['APPLICATION_TAGS','0x8' BACnetTagApplicationBitString [uint 3 'lengthValueType', uint 8 'extLength']
+ ['APPLICATION_TAGS','0x8' BACnetTagApplicationBitString (uint 3 'lengthValueType', uint 8 'extLength')
[simple uint 8 'unusedBits']
[array int 8 'data' length '(lengthValueType == 5) ? (extLength - 1) : (lengthValueType - 1)']
]
- ['APPLICATION_TAGS','0x9' BACnetTagApplicationEnumerated [uint 3 'lengthValueType', uint 8 'extLength']
+ ['APPLICATION_TAGS','0x9' BACnetTagApplicationEnumerated (uint 3 'lengthValueType', uint 8 'extLength')
[array int 8 'data' length '(lengthValueType == 5) ? extLength : lengthValueType']
]
['APPLICATION_TAGS','0xA' BACnetTagApplicationDate
@@ -583,7 +583,7 @@
]
['APPLICATION_TAGS','0xC' BACnetTagApplicationObjectIdentifier
]
- ['CONTEXT_SPECIFIC_TAGS' BACnetTagContext [uint 4 'tagNumber', uint 8 'extTagNumber', uint 3 'lengthValueType', uint 8 'extLength']
+ ['CONTEXT_SPECIFIC_TAGS' BACnetTagContext (uint 4 'tagNumber', uint 8 'extTagNumber', uint 3 'lengthValueType', uint 8 'extLength')
[array int 8 'data' length '(lengthValueType == 5) ? extLength : lengthValueType']
]
]