You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/04/10 15:49:04 UTC

[GitHub] [submarine] jojochuang commented on a change in pull request #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh

jojochuang commented on a change in pull request #259: SUBMARINE-466. [WORKBENCH] Add lib path creation into bin/submarine-daemon.sh
URL: https://github.com/apache/submarine/pull/259#discussion_r406817963
 
 

 ##########
 File path: bin/submarine-daemon.sh
 ##########
 @@ -91,7 +91,14 @@ function wait_for_submarine_server_to_die() {
 }
 
 function check_jdbc_jar() {
-  if [[ -d "${1}" ]]; then
+  if [[ ! -e "${1}" ]]; then
+    echo -e "\\033[31mError: Path '${1}' doesn't exist.\\033[0m"
 
 Review comment:
   it should a a Warn not Error

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services