You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/06/01 17:30:48 UTC

[GitHub] [accumulo] keith-turner commented on a change in pull request #2126: Unit test converting client props to BatchWriterConfig

keith-turner commented on a change in pull request #2126:
URL: https://github.com/apache/accumulo/pull/2126#discussion_r643343860



##########
File path: core/src/main/java/org/apache/accumulo/core/clientImpl/ClientContext.java
##########
@@ -284,31 +284,36 @@ public SaslConnectionParams getSaslParams() {
     return saslSupplier.get();
   }
 
-  public synchronized BatchWriterConfig getBatchWriterConfig() {
+  public synchronized static BatchWriterConfig getBatchWriterConfig(Properties props) {

Review comment:
       Synchronized should go with the instance method and not the static method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org