Re: [PR] Remove tempStorageDirectory and rely on task dir instead (druid)

["LakshSingla (via GitHub)" <gi...@apache.org>]

LakshSingla commented on code in PR #16416:
URL: https://github.com/apache/druid/pull/16416#discussion_r1630887384


##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/guice/MSQDurableStorageModule.java:
##########
@@ -84,10 +83,6 @@ public void configure(Binder binder)
           MultiStageQuery.class
       );
 
-      binder.bind(Key.get(StorageConnector.class, MultiStageQuery.class))
-            .toProvider(Key.get(StorageConnectorProvider.class, MultiStageQuery.class))
-            .in(LazySingleton.class);
-

Review Comment:
   Why is this change required? Do we still preserve the singleton nature of the storage connector? Also, we should still preserve the binding annotation. 



##########
processing/src/main/java/org/apache/druid/storage/StorageConnectorProvider.java:
##########
@@ -20,9 +20,11 @@
 package org.apache.druid.storage;
 
 import com.fasterxml.jackson.annotation.JsonTypeInfo;
-import com.google.inject.Provider;
+
+import java.io.File;
 
 @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type")
-public interface StorageConnectorProvider extends Provider<StorageConnector>
+public interface StorageConnectorProvider

Review Comment:
   I am curious why this change is needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org