You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by nick dimiduk <nd...@gmail.com> on 2014/02/26 01:07:41 UTC
Review Request 18492: HIVE-6473: Allow writing HFiles via
HBaseStorageHandler table
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18492/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-6473
https://issues.apache.org/jira/browse/HIVE-6473
Repository: hive-git
Description
-------
>From the JIRA:
Generating HFiles for bulkload into HBase could be more convenient. Right now we require the user to register a new table with the appropriate output format. This patch allows the exact same functionality, but through an existing table managed by the HBaseStorageHandler.
Diffs
-----
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java 8cd594b
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHFileOutputFormat.java 6d383b5
hbase-handler/src/test/queries/negative/generatehfiles_require_family_path.q PRE-CREATION
hbase-handler/src/test/queries/positive/hbase_bulk.m f8bb47d
hbase-handler/src/test/queries/positive/hbase_bulk.q PRE-CREATION
hbase-handler/src/test/queries/positive/hbase_handler_bulk.q PRE-CREATION
hbase-handler/src/test/results/negative/generatehfiles_require_family_path.q.out PRE-CREATION
hbase-handler/src/test/results/positive/hbase_handler_bulk.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/18492/diff/
Testing
-------
Thanks,
nick dimiduk
Re: Review Request 18492: HIVE-6473: Allow writing HFiles via
HBaseStorageHandler table
Posted by nick dimiduk <nd...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18492/
-----------------------------------------------------------
(Updated May 22, 2014, 3:53 p.m.)
Review request for hive.
Changes
-------
patch v4 from JIRA.
Bugs: HIVE-6473
https://issues.apache.org/jira/browse/HIVE-6473
Repository: hive-git
Description
-------
>From the JIRA:
Generating HFiles for bulkload into HBase could be more convenient. Right now we require the user to register a new table with the appropriate output format. This patch allows the exact same functionality, but through an existing table managed by the HBaseStorageHandler.
Diffs (updated)
-----
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java 255ffa2
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHFileOutputFormat.java be1210e
hbase-handler/src/test/queries/negative/generatehfiles_require_family_path.q PRE-CREATION
hbase-handler/src/test/queries/positive/hbase_bulk.m f8bb47d
hbase-handler/src/test/queries/positive/hbase_bulk.q PRE-CREATION
hbase-handler/src/test/queries/positive/hbase_handler_bulk.q PRE-CREATION
hbase-handler/src/test/results/negative/generatehfiles_require_family_path.q.out PRE-CREATION
hbase-handler/src/test/results/positive/hbase_bulk.q.out PRE-CREATION
hbase-handler/src/test/results/positive/hbase_handler_bulk.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/18492/diff/
Testing
-------
Thanks,
nick dimiduk
Re: Review Request 18492: HIVE-6473: Allow writing HFiles via
HBaseStorageHandler table
Posted by nick dimiduk <nd...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18492/
-----------------------------------------------------------
(Updated May 13, 2014, 4:07 a.m.)
Review request for hive.
Changes
-------
Updating diff with HIVE-6473.1.patch.txt from JIRA.
Bugs: HIVE-6473
https://issues.apache.org/jira/browse/HIVE-6473
Repository: hive-git
Description
-------
>From the JIRA:
Generating HFiles for bulkload into HBase could be more convenient. Right now we require the user to register a new table with the appropriate output format. This patch allows the exact same functionality, but through an existing table managed by the HBaseStorageHandler.
Diffs (updated)
-----
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java 4fe1b1b
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHFileOutputFormat.java be1210e
hbase-handler/src/test/queries/negative/generatehfiles_require_family_path.q PRE-CREATION
hbase-handler/src/test/queries/positive/hbase_bulk.m f8bb47d
hbase-handler/src/test/queries/positive/hbase_bulk.q PRE-CREATION
hbase-handler/src/test/queries/positive/hbase_handler_bulk.q PRE-CREATION
hbase-handler/src/test/results/negative/generatehfiles_require_family_path.q.out PRE-CREATION
hbase-handler/src/test/results/positive/hbase_bulk.q.out PRE-CREATION
hbase-handler/src/test/results/positive/hbase_handler_bulk.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/18492/diff/
Testing
-------
Thanks,
nick dimiduk
Re: Review Request 18492: HIVE-6473: Allow writing HFiles via
HBaseStorageHandler table
Posted by nick dimiduk <nd...@gmail.com>.
> On March 7, 2014, 9:01 p.m., Swarnim Kulkarni wrote:
> > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java, line 351
> > <https://reviews.apache.org/r/18492/diff/1/?file=503857#file503857line351>
> >
> > Do we have bugs logged for this or it would be covered in future revisions on the same patch?
My intention is to address this in a future patch. Nothing filed as of yet. Let me refresh my memory here and log them. Do you want this patch to refer to those issue numbers?
- nick
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18492/#review36574
-----------------------------------------------------------
On Feb. 26, 2014, 12:07 a.m., nick dimiduk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18492/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2014, 12:07 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-6473
> https://issues.apache.org/jira/browse/HIVE-6473
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> From the JIRA:
>
> Generating HFiles for bulkload into HBase could be more convenient. Right now we require the user to register a new table with the appropriate output format. This patch allows the exact same functionality, but through an existing table managed by the HBaseStorageHandler.
>
>
> Diffs
> -----
>
> hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java 8cd594b
> hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHFileOutputFormat.java 6d383b5
> hbase-handler/src/test/queries/negative/generatehfiles_require_family_path.q PRE-CREATION
> hbase-handler/src/test/queries/positive/hbase_bulk.m f8bb47d
> hbase-handler/src/test/queries/positive/hbase_bulk.q PRE-CREATION
> hbase-handler/src/test/queries/positive/hbase_handler_bulk.q PRE-CREATION
> hbase-handler/src/test/results/negative/generatehfiles_require_family_path.q.out PRE-CREATION
> hbase-handler/src/test/results/positive/hbase_handler_bulk.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18492/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> nick dimiduk
>
>
Re: Review Request 18492: HIVE-6473: Allow writing HFiles via
HBaseStorageHandler table
Posted by Swarnim Kulkarni <ku...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18492/#review36574
-----------------------------------------------------------
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
<https://reviews.apache.org/r/18492/#comment67579>
Nit: Don't need the else here.
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
<https://reviews.apache.org/r/18492/#comment67580>
Do we have bugs logged for this or it would be covered in future revisions on the same patch?
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHFileOutputFormat.java
<https://reviews.apache.org/r/18492/#comment67581>
Nit: Log.error would be more apt here.
- Swarnim Kulkarni
On Feb. 26, 2014, 12:07 a.m., nick dimiduk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18492/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2014, 12:07 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-6473
> https://issues.apache.org/jira/browse/HIVE-6473
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> From the JIRA:
>
> Generating HFiles for bulkload into HBase could be more convenient. Right now we require the user to register a new table with the appropriate output format. This patch allows the exact same functionality, but through an existing table managed by the HBaseStorageHandler.
>
>
> Diffs
> -----
>
> hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java 8cd594b
> hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHFileOutputFormat.java 6d383b5
> hbase-handler/src/test/queries/negative/generatehfiles_require_family_path.q PRE-CREATION
> hbase-handler/src/test/queries/positive/hbase_bulk.m f8bb47d
> hbase-handler/src/test/queries/positive/hbase_bulk.q PRE-CREATION
> hbase-handler/src/test/queries/positive/hbase_handler_bulk.q PRE-CREATION
> hbase-handler/src/test/results/negative/generatehfiles_require_family_path.q.out PRE-CREATION
> hbase-handler/src/test/results/positive/hbase_handler_bulk.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18492/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> nick dimiduk
>
>