You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/18 06:36:07 UTC

[GitHub] [flink] XComp opened a new pull request #13185: [docs] Replaced outdated 'RocksDBStateBackend.setOptions(..)'

XComp opened a new pull request #13185:
URL: https://github.com/apache/flink/pull/13185


   …by RocksDBStateBackend.setRocksDBOptions(..)' and fixed typo in parameter list (PptionsFactory -> RocksDBOptionsFactory).
   
   ## What is the purpose of the change
   
   This was a doc fix requested by @NicoK .
   
   ## Brief change log
   The outdated field `RocksDBStateBackend.setOptions(..)` was replaced by `RocksDBStateBackend.setRocksDBOptions(..)`.
   As part of this change, another typo got fixed: `PptionsFactory -> RocksDBOptionsFactory`
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? no
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13185: [docs] Replaced outdated 'RocksDBStateBackend.setOptions(..)'

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13185:
URL: https://github.com/apache/flink/pull/13185#issuecomment-675290910


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9fc9a7105581fdd629eee3bea9ddfde7b7953005",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9fc9a7105581fdd629eee3bea9ddfde7b7953005",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9fc9a7105581fdd629eee3bea9ddfde7b7953005 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13185: [docs] Replaced outdated 'RocksDBStateBackend.setOptions(..)'

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13185:
URL: https://github.com/apache/flink/pull/13185#issuecomment-675285674


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 9fc9a7105581fdd629eee3bea9ddfde7b7953005 (Tue Aug 18 06:38:05 UTC 2020)
   
   **Warnings:**
    * **Invalid pull request title: No valid Jira ID provided**
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13185: [docs] Replaced outdated 'RocksDBStateBackend.setOptions(..)'

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13185:
URL: https://github.com/apache/flink/pull/13185#issuecomment-675290910


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9fc9a7105581fdd629eee3bea9ddfde7b7953005",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5651",
       "triggerID" : "9fc9a7105581fdd629eee3bea9ddfde7b7953005",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9fc9a7105581fdd629eee3bea9ddfde7b7953005 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5651) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann closed pull request #13185: [docs] Replaced outdated 'RocksDBStateBackend.setOptions(..)'

Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #13185:
URL: https://github.com/apache/flink/pull/13185


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org