You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "adamsaghy (via GitHub)" <gi...@apache.org> on 2023/06/06 13:43:33 UTC
[GitHub] [fineract] adamsaghy commented on a diff in pull request #3232: FINERACT-1724: Batch API fixes + client validation fixes
adamsaghy commented on code in PR #3232:
URL: https://github.com/apache/fineract/pull/3232#discussion_r1219682213
##########
fineract-provider/src/main/java/org/apache/fineract/batch/exception/ErrorHandler.java:
##########
@@ -99,13 +99,13 @@ public static ErrorInfo handler(final RuntimeException exception) {
return handleException(e, new PlatformDomainRuleExceptionMapper(), 9999);
}
if (exception instanceof TransactionException) {
- return new ErrorInfo(HttpStatus.SC_BAD_REQUEST, 4001, "{\"Exception\": %s}".formatted(exception.getMessage()));
+ return new ErrorInfo(HttpStatus.SC_INTERNAL_SERVER_ERROR, 4001, "{\"Exception\": %s}".formatted(exception.getMessage()));
Review Comment:
if you are changing this for 5xx error, you should change the code as well (4001 -> 5001?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org