You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "kasjer (via GitHub)" <gi...@apache.org> on 2023/07/14 07:03:04 UTC

[GitHub] [mynewt-core] kasjer opened a new pull request, #3040: hw/drivers/flash/spiflash: Make SPI mode configurable

kasjer opened a new pull request, #3040:
URL: https://github.com/apache/mynewt-core/pull/3040

   SPI mode for hardcoded to HAL_SPI_MODE3, most SPI flashes also support HAL_SPI_MODE0.
   Now user can specify which mode to use.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [mynewt-core] kasjer commented on pull request #3040: hw/drivers/flash/spiflash: Make SPI mode configurable

Posted by "kasjer (via GitHub)" <gi...@apache.org>.
kasjer commented on PR #3040:
URL: https://github.com/apache/mynewt-core/pull/3040#issuecomment-1636188916

   @wes3 good catch, you are technically correct. Two BSP in question are nucleo-h723 and nucleo-u575 those are recent addition to mynewt and we added support for spi flash just to make example how it works.
   None of the Nucleo boards I know of (those two included) has any SPI Flash on board so it does not spoil anything I think and now mode is configurable.
   I made option just to make it easier on Logic analyzer when lot of other device uses MODE0.
   Clock idle state 0 or 1 could be related to power consumption so user can choose which one to use while for SPI Flash it does not matter much.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [mynewt-core] kasjer merged pull request #3040: hw/drivers/flash/spiflash: Make SPI mode configurable

Posted by "kasjer (via GitHub)" <gi...@apache.org>.
kasjer merged PR #3040:
URL: https://github.com/apache/mynewt-core/pull/3040


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [mynewt-core] kasjer commented on pull request #3040: hw/drivers/flash/spiflash: Make SPI mode configurable

Posted by "kasjer (via GitHub)" <gi...@apache.org>.
kasjer commented on PR #3040:
URL: https://github.com/apache/mynewt-core/pull/3040#issuecomment-1655975295

   > @kasjer Are you waiting for approval on this? I think a coding style check failed.
   
   I could reformat section that style checker complains about but this is style was approved way back.
   Whole file could be re-formatted but we usually don't do this just to make style checker happy.
   
   So offending code changes value keeping format style consistent with the rest of surrounding lines.
   So basically what I'm trying to say that this change does not introduce new style error just keeps existing spaces.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [mynewt-core] wes3 commented on pull request #3040: hw/drivers/flash/spiflash: Make SPI mode configurable

Posted by "wes3 (via GitHub)" <gi...@apache.org>.
wes3 commented on PR #3040:
URL: https://github.com/apache/mynewt-core/pull/3040#issuecomment-1655967750

   @kasjer Are you waiting for approval on this? I think a coding style check failed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org