You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "Dongjoon Hyun (Jira)" <ji...@apache.org> on 2021/10/12 23:22:00 UTC
[jira] [Commented] (ORC-1026) when write string type column,need to traversing the dictionary when flushDictionary method is called,Is there anyway to remove this travesing
[ https://issues.apache.org/jira/browse/ORC-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427954#comment-17427954 ]
Dongjoon Hyun commented on ORC-1026:
------------------------------------
Thank you for filing a JIRA, [~jiaoqb]. BTW, what is the goal you want to achieve through this JIRA?
> when write string type column,need to traversing the dictionary when flushDictionary method is called,Is there anyway to remove this travesing
> ----------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ORC-1026
> URL: https://issues.apache.org/jira/browse/ORC-1026
> Project: ORC
> Issue Type: Improvement
> Components: Java
> Affects Versions: 1.8.0
> Reporter: qingbo jiao
> Priority: Major
>
> In the StringBaseTreeWriter.class when called flushDictionary() method,where traversing the dictionary as show below
> {code:java}
> dictionary.visit(new Dictionary.Visitor() {
> private int currentId = 0;
> @Override
> public void visit(Dictionary.VisitorContext context
> ) throws IOException {
> context.writeBytes(stringOutput);
> lengthOutput.write(context.getLength());
> dumpOrder[context.getOriginalPosition()] = currentId++;
> }
> });
> {code}
> In the Impl class,we had some array to hold the information needed here
--
This message was sent by Atlassian Jira
(v8.3.4#803005)