You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/12/15 03:45:26 UTC
[GitHub] [iotdb] cigarl opened a new pull request #4575: Simplify the recovery merge process
cigarl opened a new pull request #4575:
URL: https://github.com/apache/iotdb/pull/4575
Simply the `MergeRecoveryTask`, we may just need to clean last info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a change in pull request #4575: [IOTDB-2162] Simplify the recovery merge process
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #4575:
URL: https://github.com/apache/iotdb/pull/4575#discussion_r770644941
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/cross/inplace/task/CleanLastMergeTask.java
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.engine.compaction.cross.inplace.task;
+
+import org.apache.iotdb.db.engine.storagegroup.TsFileResource;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * RecoverCrossMergeTask is an extension of MergeTask, which resumes the last merge progress by
+ * scanning merge.log using LogAnalyzer and continue the unfinished merge.
+ */
+public class CleanLastMergeTask extends CrossSpaceMergeTask {
Review comment:
In master, we'd better rename merge to cross space compaction.
Another is inner space compaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] cigarl commented on a change in pull request #4575: [IOTDB-2162] Simplify the recovery merge process
Posted by GitBox <gi...@apache.org>.
cigarl commented on a change in pull request #4575:
URL: https://github.com/apache/iotdb/pull/4575#discussion_r771147658
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/cross/inplace/task/CleanLastMergeTask.java
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.engine.compaction.cross.inplace.task;
+
+import org.apache.iotdb.db.engine.storagegroup.TsFileResource;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * RecoverCrossMergeTask is an extension of MergeTask, which resumes the last merge progress by
+ * scanning merge.log using LogAnalyzer and continue the unfinished merge.
+ */
+public class CleanLastMergeTask extends CrossSpaceMergeTask {
Review comment:
ok~ the related names have been changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on pull request #4575: Simplify the recovery merge process
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on pull request #4575:
URL: https://github.com/apache/iotdb/pull/4575#issuecomment-995363393
I suggest we raise a jira firstly, and then raise pr.. So we can get a good tally of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] cigarl commented on pull request #4575: [IOTDB-2162] Simplify the recovery merge process
Posted by GitBox <gi...@apache.org>.
cigarl commented on pull request #4575:
URL: https://github.com/apache/iotdb/pull/4575#issuecomment-995377396
> I suggest we raise a jira firstly, and then raise pr.. So we can get a good tally of.
Thanks for your reminding, I have created a [issue](https://issues.apache.org/jira/projects/IOTDB/issues/IOTDB-2162?filter=allopenissues).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #4575: [IOTDB-2162] Simplify the recovery merge process
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #4575:
URL: https://github.com/apache/iotdb/pull/4575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org