You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/10/14 16:37:00 UTC
[jira] [Commented] (LUCENE-8979) Code Cleanup: Use entryset for map
iteration wherever possible - part 2 possible.
[ https://issues.apache.org/jira/browse/LUCENE-8979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951131#comment-16951131 ]
ASF subversion and git services commented on LUCENE-8979:
---------------------------------------------------------
Commit 04786244d0ae37eef88948c7fdfb5ccb84ca47da in lucene-solr's branch refs/heads/master from Koen De Groote
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=0478624 ]
LUCENE-8979: Code Cleanup: Use entryset for map iteration wherever possible. - part 2
> Code Cleanup: Use entryset for map iteration wherever possible - part 2 possible.
> ---------------------------------------------------------------------------------
>
> Key: LUCENE-8979
> URL: https://issues.apache.org/jira/browse/LUCENE-8979
> Project: Lucene - Core
> Issue Type: Improvement
> Affects Versions: 8.2
> Reporter: Koen De Groote
> Priority: Trivial
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> For some reason, not all issues had been picked up in the previous ticket. This should be all of them. My bad I suppose.
>
> ==========================
>
> Simple, non-important code cleanup.
> Again, to clarify, please don't bother yourself with this ticket on company time, on personal time you could be working on something that makes you money or improves the product for your feature personally.
>
> This entire ticket is an afterthough. A look back at the code base that most people don't have the time for.
>
> ================
>
> While true that using `entrySet()` is really only an improvement for traversing a TreeMap(at least that's how it was in JDK8), it's a good practice in general to use it over keySet(), if you then use that keyset to do an extra lookup to get the value as well as the key.
>
> So that's what this ticket is.
>
> All changes were done automatically via Intellij's built-in code analysis.
>
> Putting this on LUCENE because code both in lucene and solr was changed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org