You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/09/04 03:38:46 UTC
[GitHub] [kafka] jiweiautohome opened a new pull request #9250: KAFKA-10461 The config of closing heartbeat is invalid.
jiweiautohome opened a new pull request #9250:
URL: https://github.com/apache/kafka/pull/9250
https://issues.apache.org/jira/projects/KAFKA/issues/KAFKA-10461?filter=allissues
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9250: KAFKA-10461 The config of closing heartbeat is invalid.
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9250:
URL: https://github.com/apache/kafka/pull/9250#issuecomment-691601314
https://github.com/apache/kafka/blob/trunk/connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorHeartbeatConnector.java#L64
```
@Override
public List<Map<String, String>> taskConfigs(int maxTasks) {
// if the heartbeats emission is disabled by setting `emit.heartbeats.enabled` to `false`,
// the interval heartbeat emission will be negative and no `MirrorHeartbeatTask` will be created
if (config.emitHeartbeatsInterval().isNegative()) {
return Collections.emptyList();
}
// just need a single task
return Collections.singletonList(config.originalsStrings());
}
```
It seems that no task will be created if ```emit.heartbeats.enabled``` is set to false. Do you observe something weird?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jiweiautohome commented on pull request #9250: KAFKA-10461 The config of closing heartbeat is invalid.
Posted by GitBox <gi...@apache.org>.
jiweiautohome commented on pull request #9250:
URL: https://github.com/apache/kafka/pull/9250#issuecomment-691780087
> Could you add unit test?
The version of kafka we using is 2.4. It's fixed in 2.5.
https://github.com/apache/kafka/blob/16ec1793d53700623c9cb43e711f585aafd44dd4/connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorHeartbeatConnector.java#L64
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9250: KAFKA-10461 The config of closing heartbeat is invalid.
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9250:
URL: https://github.com/apache/kafka/pull/9250#issuecomment-691600174
Could you add unit test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jiweiautohome commented on pull request #9250: KAFKA-10461 The config of closing heartbeat is invalid.
Posted by GitBox <gi...@apache.org>.
jiweiautohome commented on pull request #9250:
URL: https://github.com/apache/kafka/pull/9250#issuecomment-691780660
The version of kafka we using is 2.4. It's fixed in 2.5.
https://github.com/apache/kafka/blob/5fa66b3b8c43c4e7de591704581de88fd911a705/connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorHeartbeatConnector.java#L54
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jiweiautohome closed pull request #9250: KAFKA-10461 The config of closing heartbeat is invalid.
Posted by GitBox <gi...@apache.org>.
jiweiautohome closed pull request #9250:
URL: https://github.com/apache/kafka/pull/9250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jiweiautohome removed a comment on pull request #9250: KAFKA-10461 The config of closing heartbeat is invalid.
Posted by GitBox <gi...@apache.org>.
jiweiautohome removed a comment on pull request #9250:
URL: https://github.com/apache/kafka/pull/9250#issuecomment-691780087
> Could you add unit test?
The version of kafka we using is 2.4. It's fixed in 2.5.
https://github.com/apache/kafka/blob/16ec1793d53700623c9cb43e711f585aafd44dd4/connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorHeartbeatConnector.java#L64
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org