You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2004/02/19 00:16:53 UTC
cvs commit: jakarta-jmeter/src/core/org/apache/jmeter/util JMeterUtils.java
sebb 2004/02/18 15:16:53
Modified: src/core/org/apache/jmeter/util JMeterUtils.java
Log:
Fix useless use of trim(); close file on normal exit
Revision Changes Path
1.64 +6 -5 jakarta-jmeter/src/core/org/apache/jmeter/util/JMeterUtils.java
Index: JMeterUtils.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/util/JMeterUtils.java,v
retrieving revision 1.63
retrieving revision 1.64
diff -u -r1.63 -r1.64
--- JMeterUtils.java 13 Feb 2004 02:21:37 -0000 1.63
+++ JMeterUtils.java 18 Feb 2004 23:16:53 -0000 1.64
@@ -369,6 +369,7 @@
text.append(lineEnd);
}
}
+ fileReader.close();
return text.toString();
}
catch (NullPointerException e) // Cannot find file
@@ -676,12 +677,12 @@
{
if (className != null)
{
- className.trim();//TODO does nothing - presumably should be s=className.trim()
+ className=className.trim();
}
if (impls != null)
- { // FIXME: Shouldn't this be impls.trim()?
- className.trim();//TODO does nothing!!
+ {
+ impls=impls.trim();
}
try
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org