You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ankit Singhal <an...@apache.org> on 2018/08/20 18:14:04 UTC
Re: Review Request 65950: Add support to allow clients to access
resource permissions stored in Ranger
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65950/
-----------------------------------------------------------
(Updated Aug. 20, 2018, 6:14 p.m.)
Review request for ranger and Ramesh Mani.
Changes
-------
Now leveraged RANGER-2061 to implement getUserPermissions() API of HBase plugin
Bugs: RANGER-1958
https://issues.apache.org/jira/browse/RANGER-1958
Repository: ranger
Description
-------
RANGER-1958 [HBase] Implement getUserPermissions API of AccessControlService.Interface to allow clients to access HBase permissions stored in Ranger
Diffs (updated)
-----
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java cdaad00a4
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java d85339a09
hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java 38408855d
hbase-agent/src/test/resources/hbase-policies.json b7b44c9ea
Diff: https://reviews.apache.org/r/65950/diff/2/
Changes: https://reviews.apache.org/r/65950/diff/1-2/
Testing
-------
Unit testing is done
Thanks,
Ankit Singhal
Re: Review Request 65950: Add support to allow clients to access
resource permissions stored in Ranger
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65950/#review209155
-----------------------------------------------------------
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java
Lines 36 (patched)
<https://reviews.apache.org/r/65950/#comment293449>
Could you please fix PMD violations?
```
[INFO] --- maven-pmd-plugin:3.7:check (default) @ ranger-hbase-plugin ---
[INFO] PMD Failure: org/apache/ranger/authorization/hbase/AuthorizationSession.java:36 Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.ranger.plugin.policyengine.RangerResourceACLs'.
[INFO] PMD Failure: org.apache.ranger.authorization.hbase.HBaseRangerAuthorizationTest:1007 Rule:UnusedLocalVariable Priority:3 Avoid unused local variables such as 'userPermission'..
```
hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java
Lines 1007 (patched)
<https://reviews.apache.org/r/65950/#comment293450>
Please fix PMD violation.
```
[INFO] --- maven-pmd-plugin:3.7:check (default) @ ranger-hbase-plugin ---
[INFO] PMD Failure: org/apache/ranger/authorization/hbase/AuthorizationSession.java:36 Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.ranger.plugin.policyengine.RangerResourceACLs'.
[INFO] PMD Failure: org.apache.ranger.authorization.hbase.HBaseRangerAuthorizationTest:1007 Rule:UnusedLocalVariable Priority:3 Avoid unused local variables such as 'userPermission'..
```
- Velmurugan Periasamy
On Sept. 26, 2018, 10:40 p.m., Ankit Singhal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65950/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2018, 10:40 p.m.)
>
>
> Review request for ranger and Ramesh Mani.
>
>
> Bugs: RANGER-1958
> https://issues.apache.org/jira/browse/RANGER-1958
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-1958 [HBase] Implement getUserPermissions API of AccessControlService.Interface to allow clients to access HBase permissions stored in Ranger
>
>
> Diffs
> -----
>
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java cdaad00a4
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java d85339a09
> hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java 38408855d
> hbase-agent/src/test/resources/hbase-policies.json b7b44c9ea
>
>
> Diff: https://reviews.apache.org/r/65950/diff/3/
>
>
> Testing
> -------
>
> Unit testing is done
>
>
> Thanks,
>
> Ankit Singhal
>
>
Re: Review Request 65950: Add support to allow clients to access
resource permissions stored in Ranger
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65950/#review209281
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On Oct. 4, 2018, 11:38 p.m., Ankit Singhal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65950/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2018, 11:38 p.m.)
>
>
> Review request for ranger and Ramesh Mani.
>
>
> Bugs: RANGER-1958
> https://issues.apache.org/jira/browse/RANGER-1958
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-1958 [HBase] Implement getUserPermissions API of AccessControlService.Interface to allow clients to access HBase permissions stored in Ranger
>
>
> Diffs
> -----
>
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java cdaad00a4
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java d85339a09
> hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java 38408855d
> hbase-agent/src/test/resources/hbase-policies.json b7b44c9ea
>
>
> Diff: https://reviews.apache.org/r/65950/diff/4/
>
>
> Testing
> -------
>
> Unit testing is done
>
>
> Thanks,
>
> Ankit Singhal
>
>
Re: Review Request 65950: Add support to allow clients to access
resource permissions stored in Ranger
Posted by Ankit Singhal <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65950/
-----------------------------------------------------------
(Updated Oct. 4, 2018, 11:38 p.m.)
Review request for ranger and Ramesh Mani.
Bugs: RANGER-1958
https://issues.apache.org/jira/browse/RANGER-1958
Repository: ranger
Description
-------
RANGER-1958 [HBase] Implement getUserPermissions API of AccessControlService.Interface to allow clients to access HBase permissions stored in Ranger
Diffs (updated)
-----
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java cdaad00a4
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java d85339a09
hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java 38408855d
hbase-agent/src/test/resources/hbase-policies.json b7b44c9ea
Diff: https://reviews.apache.org/r/65950/diff/4/
Changes: https://reviews.apache.org/r/65950/diff/3-4/
Testing
-------
Unit testing is done
Thanks,
Ankit Singhal
Re: Review Request 65950: Add support to allow clients to access
resource permissions stored in Ranger
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65950/#review209056
-----------------------------------------------------------
Ship it!
Ship It!
- Ramesh Mani
On Sept. 26, 2018, 10:40 p.m., Ankit Singhal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65950/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2018, 10:40 p.m.)
>
>
> Review request for ranger and Ramesh Mani.
>
>
> Bugs: RANGER-1958
> https://issues.apache.org/jira/browse/RANGER-1958
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-1958 [HBase] Implement getUserPermissions API of AccessControlService.Interface to allow clients to access HBase permissions stored in Ranger
>
>
> Diffs
> -----
>
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java cdaad00a4
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java d85339a09
> hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java 38408855d
> hbase-agent/src/test/resources/hbase-policies.json b7b44c9ea
>
>
> Diff: https://reviews.apache.org/r/65950/diff/3/
>
>
> Testing
> -------
>
> Unit testing is done
>
>
> Thanks,
>
> Ankit Singhal
>
>
Re: Review Request 65950: Add support to allow clients to access
resource permissions stored in Ranger
Posted by Ankit Singhal <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65950/
-----------------------------------------------------------
(Updated Sept. 26, 2018, 10:40 p.m.)
Review request for ranger and Ramesh Mani.
Changes
-------
removed permissionAccess.getValue().getIsFinal() unnecessary check as per Abhay Kulkarni review comment.
Bugs: RANGER-1958
https://issues.apache.org/jira/browse/RANGER-1958
Repository: ranger
Description
-------
RANGER-1958 [HBase] Implement getUserPermissions API of AccessControlService.Interface to allow clients to access HBase permissions stored in Ranger
Diffs (updated)
-----
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java cdaad00a4
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java d85339a09
hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java 38408855d
hbase-agent/src/test/resources/hbase-policies.json b7b44c9ea
Diff: https://reviews.apache.org/r/65950/diff/3/
Changes: https://reviews.apache.org/r/65950/diff/2-3/
Testing
-------
Unit testing is done
Thanks,
Ankit Singhal
Re: Review Request 65950: Add support to allow clients to access
resource permissions stored in Ranger
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65950/#review208528
-----------------------------------------------------------
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java
Lines 1377 (patched)
<https://reviews.apache.org/r/65950/#comment292515>
Is the check, permissionAccess.getValue().getIsFinal(), required? All permissionAccesses are set to final in RangerResourceACLs.finalizeAcls().
- Abhay Kulkarni
On Aug. 20, 2018, 6:14 p.m., Ankit Singhal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65950/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2018, 6:14 p.m.)
>
>
> Review request for ranger and Ramesh Mani.
>
>
> Bugs: RANGER-1958
> https://issues.apache.org/jira/browse/RANGER-1958
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-1958 [HBase] Implement getUserPermissions API of AccessControlService.Interface to allow clients to access HBase permissions stored in Ranger
>
>
> Diffs
> -----
>
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java cdaad00a4
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java d85339a09
> hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java 38408855d
> hbase-agent/src/test/resources/hbase-policies.json b7b44c9ea
>
>
> Diff: https://reviews.apache.org/r/65950/diff/2/
>
>
> Testing
> -------
>
> Unit testing is done
>
>
> Thanks,
>
> Ankit Singhal
>
>