[GitHub] [phoenix] stoty commented on a diff in pull request #1534: PHOENIX-6655 - SYSTEM.SEQUENCE should have CACHE_DATA_ON_WRITE set to…

[GitBox <gi...@apache.org>]

stoty commented on code in PR #1534:
URL: https://github.com/apache/phoenix/pull/1534#discussion_r1048149316


##########
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##########
@@ -3540,11 +3540,18 @@ Collections.<Class<? extends Exception>> singletonList(
                                 if (!ConnectionQueryServicesImpl.this.upgradeRequired.get()) {
                                     if (!isDoNotUpgradePropSet) {
                                         createOtherSystemTables(metaConnection);
+
+                                        // When creating the tables above, DDL statements are
+                                        // used. However, the CFD level properties are not set
+                                        // via DDL commands, hence we are explicitly setting
+                                        // few properties using the Admin API below.
+                                        updateSystemSequenceWithCacheOnWriteProps(metaConnection);

Review Comment:
   This call should be pushed into createOtherSystemTables, to improve readability.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org