[jira] [Commented] (AMBARI-24849) Add Information to the SPI to Support Upgrade Checks

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-24849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669465#comment-16669465 ] 

Hudson commented on AMBARI-24849:
---------------------------------

SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #10257 (See [https://builds.apache.org/job/Ambari-trunk-Commit/10257/])
[AMBARI-24849] Add Information to the SPI to Support Upgrade Checks (github: [https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=d7ce1ef3668d551061fa0539fda7befdb6cb1b43])
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/HealthCheckTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/ConfigurationMergeCheckTest.java
* (edit) ambari-server-spi/src/main/java/org/apache/ambari/spi/upgrade/UpgradeCheck.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/ClusterCheckTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/VersionMismatchCheckTest.java
* (edit) ambari-server-spi/src/main/java/org/apache/ambari/spi/RepositoryVersion.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BootStrapImpl.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/MissingOsInRepoVersionCheckTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/ServicePresenceCheckTest.java
* (delete) ambari-server/src/main/java/org/apache/ambari/server/utils/VersionUtils.java
* (edit) ambari-server-spi/src/main/java/org/apache/ambari/spi/upgrade/UpgradeCheckDescription.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/utils/TestVersionUtils.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/HostMaintenanceModeCheckTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheckTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/checks/ClusterCheck.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/RequiredServicesInRepositoryCheckTest.java
* (edit) ambari-server-spi/src/main/java/org/apache/ambari/spi/ClusterInformation.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheckTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProviderTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/ComponentExistsInRepoCheckTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/state/CheckHelper.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/ComponentsInstallationCheckTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/KerberosAdminPersistedCredentialCheckTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/LZOCheckTest.java
* (edit) ambari-server-spi/pom.xml
* (edit) ambari-server-spi/src/main/java/org/apache/ambari/spi/upgrade/UpgradeCheckResult.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/AmbariMetricsHadoopSinkVersionCheckTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/HostsHeartbeatCheckTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/InstallPackagesCheckTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/PreviousUpgradeCompletedTest.java
* (add) ambari-server-spi/src/main/java/org/apache/ambari/server/utils/VersionUtils.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/state/CheckHelperTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/UpgradeTypeQualificationTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheckTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java


> Add Information to the SPI to Support Upgrade Checks
> ----------------------------------------------------
>
>                 Key: AMBARI-24849
>                 URL: https://issues.apache.org/jira/browse/AMBARI-24849
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-server-spi
>    Affects Versions: 2.8.0
>            Reporter: Jonathan Hurley
>            Assignee: Jonathan Hurley
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 2.8.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> While implementing some of the upgrade checks which were removed as part of AMBARI-24737, the SPI needed some extra information added.
> - Some checks used {{VersionUtils}}, so this needed to be relocated to the SPI.
> - Added service-level repository version information to {{ClusterInformation}}
> - Simplified the {{UpgradeCheckDescription}} when there is only 1 failure message.
> - Prevent NPE when {{CheckQualifications}} is {{null}} (even though Javadoc says it must return an empty iist.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)