You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/05/14 23:53:32 UTC
[PR] GH-41652: [C++][CMake][Windows] Don't build needless object libraries [arrow]
kou opened a new pull request, #41658:
URL: https://github.com/apache/arrow/pull/41658
### Rationale for this change
* We don't need an object library for a shared library with `ARROW_BUILD_SHARED=OFF`.
* We don't need an object library for a static library with `ARROW_BUILD_STATIC=OFF`.
### What changes are included in this PR?
Don't build needless object libraries based on `ARROW_BUILD_SHARED`/`ARROW_BUILD_STATIC`.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41652: [C++][CMake][Windows] Don't build needless object libraries [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41658:
URL: https://github.com/apache/arrow/pull/41658#issuecomment-2111345805
Revision: 78c9fb526be99b862c51e5489a1577a11c56748f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-e879a5cb94](https://github.com/ursacomputing/crossbow/branches/all?query=actions-e879a5cb94)
|Task|Status|
|----|------|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/9087747315/job/24976053931)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/9087747316/job/24976053932)|
|wheel-windows-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/9087747334/job/24976054036)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/9087747359/job/24976054098)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/9087747280/job/24976053771)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41652: [C++][CMake][Windows] Don't build needless object libraries [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #41658:
URL: https://github.com/apache/arrow/pull/41658#issuecomment-2160914247
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 290e606c4dd937cd34dbccd6f6801ff1ac1d8b9b.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/26081692261) has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41652: [C++][CMake][Windows] Don't build needless object libraries [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41658:
URL: https://github.com/apache/arrow/pull/41658#issuecomment-2111342631
:warning: GitHub issue #41652 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41652: [C++][CMake][Windows] Don't build needless object libraries [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #41658:
URL: https://github.com/apache/arrow/pull/41658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41652: [C++][CMake][Windows] Don't build needless object libraries [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #41658:
URL: https://github.com/apache/arrow/pull/41658#issuecomment-2111344023
@github-actions crossbow submit wheel-windows-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41652: [C++][CMake][Windows] Don't build needless object libraries [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #41658:
URL: https://github.com/apache/arrow/pull/41658#issuecomment-2153743226
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org