[GitHub] drill pull request #1066: DRILL-3993: Changes to support Calcite 1.15

[chunhui-shi <gi...@git.apache.org>]

Github user chunhui-shi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1066#discussion_r161077516
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/AggPruleBase.java ---
    @@ -82,4 +83,19 @@ protected boolean create2PhasePlan(RelOptRuleCall call, DrillAggregateRel aggreg
         }
         return true;
       }
    +
    +  /**
    +   * Returns group-by keys with the remapped arguments for specified aggregate.
    +   *
    +   * @param groupSet ImmutableBitSet of aggregate rel node, whose group-by keys should be remapped.
    +   * @return {@link ImmutableBitSet} instance with remapped keys.
    +   */
    +  public static ImmutableBitSet remapGroupSet(ImmutableBitSet groupSet) {
    --- End diff --
    
    what is the reason we are going this remap with new calcite? 
    And if the result is only depended on size of groupSet, we don't really need to iterate through the groupSet.


---