You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2017/03/22 20:33:47 UTC
Review Request 57860: Docker environment gets passed by key and
invocation environment.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57860/
-----------------------------------------------------------
Review request for mesos, Adam B, Alexander Rukletsov, Gilbert Song, James DeFelice, Jie Yu, and Joseph Wu.
Bugs: MESOS-6951
https://issues.apache.org/jira/browse/MESOS-6951
Repository: mesos
Description
-------
Manually backported for 1.2.x.
Diffs
-----
src/docker/docker.cpp 68042fd6f3b19c12cddd0d2e74ae064ceceb6a8c
Diff: https://reviews.apache.org/r/57860/diff/1/
Testing
-------
testing ongoing....
Thanks,
Till Toenshoff
Re: Review Request 57860: Docker environment gets passed on docker run
command.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57860/#review169980
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On March 24, 2017, 5:08 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57860/
> -----------------------------------------------------------
>
> (Updated March 24, 2017, 5:08 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, Gilbert Song, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-6951
> https://issues.apache.org/jira/browse/MESOS-6951
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removes the use of --env_file as that does not support newlines
> in environment variable values. Also avoids leaking of possibly
> sensitive environment variables to the log.
>
> Manually backported for 1.2.x.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 68042fd6f3b19c12cddd0d2e74ae064ceceb6a8c
>
>
> Diff: https://reviews.apache.org/r/57860/diff/4/
>
>
> Testing
> -------
>
> make check & sudo ./bin/mesos-tests.sh
>
> Functional testing.
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 57860: Docker environment gets passed on docker run
command.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57860/
-----------------------------------------------------------
(Updated March 24, 2017, 5:08 a.m.)
Review request for mesos, Adam B, Alexander Rukletsov, Gilbert Song, James DeFelice, Jie Yu, and Joseph Wu.
Changes
-------
Removed unrelated patch that snuck in.
Bugs: MESOS-6951
https://issues.apache.org/jira/browse/MESOS-6951
Repository: mesos
Description
-------
Removes the use of --env_file as that does not support newlines in
environment variable values.
Removes leaking of possibly sensitive environment variables to the log.
Manually backported for 1.2.x.
Diffs (updated)
-----
src/docker/docker.cpp 68042fd6f3b19c12cddd0d2e74ae064ceceb6a8c
Diff: https://reviews.apache.org/r/57860/diff/3/
Changes: https://reviews.apache.org/r/57860/diff/2-3/
Testing
-------
make check & sudo ./bin/mesos-tests.sh
Functional testing.
Thanks,
Till Toenshoff
Re: Review Request 57860: Docker environment gets passed by key and
invocation environment.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57860/#review169837
-----------------------------------------------------------
Bad patch!
Reviews applied: [57860]
Failed command: python support/apply-reviews.py -n -r 57860
Error:
2017-03-23 03:42:36 URL:https://reviews.apache.org/r/57860/diff/raw/ [3831/3831] -> "57860.patch" [1]
error: patch failed: src/docker/docker.cpp:532
error: src/docker/docker.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/17529/console
- Mesos Reviewbot
On March 22, 2017, 8:33 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57860/
> -----------------------------------------------------------
>
> (Updated March 22, 2017, 8:33 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, Gilbert Song, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-6951
> https://issues.apache.org/jira/browse/MESOS-6951
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Manually backported for 1.2.x.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 68042fd6f3b19c12cddd0d2e74ae064ceceb6a8c
>
>
> Diff: https://reviews.apache.org/r/57860/diff/1/
>
>
> Testing
> -------
>
> make check & sudo ./bin/mesos-tests.sh
>
> Functional testing - running ps while docker test active to confirm we do not leak values to the commandline;
>
> ```
> /usr/bin/docker-current -H unix:///var/run/docker.sock run --cpu-shares 2048 --memory 1073741824 -e MESOS_CONTAINER_NAME -e MESOS_SANDBOX -v /tmp/DockerContainerizerTest_ROOT_DOCKER_TaskKillingCapability_15mNp9/slaves/0892768e-2de9-4ce1-bfcf-206f1e74926a-S0/frameworks/0892768e-2de9-4ce1-bfcf-206f1e74926a-0000/executors/1/runs/1e815a9f-87d1-4f43-a197-3e7e34d03d1b:/mnt/mes
> ```
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 57860: Docker environment gets passed by key and
invocation environment.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57860/#review169823
-----------------------------------------------------------
src/docker/docker.cpp
Lines 825 (patched)
<https://reviews.apache.org/r/57860/#comment242474>
What if `environmentVariables` has env vars with the same names that vars from `os::environment()`? Looks like the task's env will be changed!
- Alexander Rukletsov
On March 22, 2017, 8:33 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57860/
> -----------------------------------------------------------
>
> (Updated March 22, 2017, 8:33 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, Gilbert Song, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-6951
> https://issues.apache.org/jira/browse/MESOS-6951
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Manually backported for 1.2.x.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 68042fd6f3b19c12cddd0d2e74ae064ceceb6a8c
>
>
> Diff: https://reviews.apache.org/r/57860/diff/1/
>
>
> Testing
> -------
>
> make check & sudo ./bin/mesos-tests.sh
>
> Functional testing - running ps while docker test active to confirm we do not leak values to the commandline;
>
> ```
> /usr/bin/docker-current -H unix:///var/run/docker.sock run --cpu-shares 2048 --memory 1073741824 -e MESOS_CONTAINER_NAME -e MESOS_SANDBOX -v /tmp/DockerContainerizerTest_ROOT_DOCKER_TaskKillingCapability_15mNp9/slaves/0892768e-2de9-4ce1-bfcf-206f1e74926a-S0/frameworks/0892768e-2de9-4ce1-bfcf-206f1e74926a-0000/executors/1/runs/1e815a9f-87d1-4f43-a197-3e7e34d03d1b:/mnt/mes
> ```
>
>
> Thanks,
>
> Till Toenshoff
>
>