[GitHub] [openoffice] leginee commented on pull request #115: Flaky tests

[GitBox <gi...@apache.org>]

leginee commented on pull request #115:
URL: https://github.com/apache/openoffice/pull/115#issuecomment-757465959


   I checked through the code and for me it is fine. I have a question thought.
   The assert call had always a parameter as a implicit nested Function. and you broke that up, by declaring a variable first and then hand it to the assert function. Did you do this for style reasons or was there a deeper technical thought behind it?
   Also note that the sleep comes always directly in front of the assert, so there is a change. That is why I wonder a bit.
   I like the structure, because it is cleaner now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org