You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/12/13 08:05:45 UTC

[GitHub] [ignite-3] isapego commented on a diff in pull request #1440: IGNITE-17588 SQL API for C++ Client

isapego commented on code in PR #1440:
URL: https://github.com/apache/ignite-3/pull/1440#discussion_r1046773827


##########
modules/platforms/cpp/ignite/protocol/utils.cpp:
##########
@@ -28,20 +28,73 @@
 
 namespace ignite::protocol {
 
+/**
+ * Check if int value fits in @c T.
+ *
+ * @tparam T Int type to fit value to.
+ * @param value Int value.
+ */
+template<typename T>
+inline void check_int_fits(std::int64_t value) {

Review Comment:
   In C implementation you can only check for `MSGPACK_OBJECT_NEGATIVE_INTEGER` or  `MSGPACK_OBJECT_POSITIVE_INTEGER`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org