You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by fe...@apache.org on 2011/03/25 09:20:52 UTC
svn commit: r1085279 -
/directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/shared/ldap/model/name/Dn.java
Author: felixk
Date: Fri Mar 25 08:20:51 2011
New Revision: 1085279
URL: http://svn.apache.org/viewvc?rev=1085279&view=rev
Log:
Compare the value not the type, this is done already using if instanceof.
Modified:
directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/shared/ldap/model/name/Dn.java
Modified: directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/shared/ldap/model/name/Dn.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/shared/ldap/model/name/Dn.java?rev=1085279&r1=1085278&r2=1085279&view=diff
==============================================================================
--- directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/shared/ldap/model/name/Dn.java (original)
+++ directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/shared/ldap/model/name/Dn.java Fri Mar 25 08:20:51 2011
@@ -1040,7 +1040,7 @@ public class Dn implements Iterable<Rdn>
{
if ( obj instanceof String )
{
- return normName.equals( obj );
+ return normName.equals( (String) obj );
}
else if ( obj instanceof Dn)
{
Re: svn commit: r1085279 - /directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/shared/ldap/model/name/Dn.java
Posted by Emmanuel Lecharny <el...@gmail.com>.
On 3/25/11 9:20 AM, felixk@apache.org wrote:
> Author: felixk
> Date: Fri Mar 25 08:20:51 2011
> New Revision: 1085279
>
> URL: http://svn.apache.org/viewvc?rev=1085279&view=rev
> Log:
> Compare the value not the type, this is done already using if instanceof.
I'm not sure you need to cast the obj. The equals method only accept an
Object anyway...
> Modified:
> directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/shared/ldap/model/name/Dn.java
>
> Modified: directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/shared/ldap/model/name/Dn.java
> URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/shared/ldap/model/name/Dn.java?rev=1085279&r1=1085278&r2=1085279&view=diff
> ==============================================================================
> --- directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/shared/ldap/model/name/Dn.java (original)
> +++ directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/shared/ldap/model/name/Dn.java Fri Mar 25 08:20:51 2011
> @@ -1040,7 +1040,7 @@ public class Dn implements Iterable<Rdn>
> {
> if ( obj instanceof String )
> {
> - return normName.equals( obj );
> + return normName.equals( (String) obj );
> }
> else if ( obj instanceof Dn)
> {
>
>
>
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com