You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergio Pena via Review Board <no...@reviews.apache.org> on 2018/05/02 16:44:56 UTC
Review Request 66909: HIVE-19372: Add table ownerType to JDO/SQL and
ObjectStore
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66909/
-----------------------------------------------------------
Review request for hive, Alexander Kolbasov, Sahil Takiar, and Vihang Karajgaonkar.
Bugs: HIVE-19372
https://issues.apache.org/jira/browse/HIVE-19372
Repository: hive-git
Description
-------
This is a subtask part of 'HIVE-18762 Support ALTER TABLE SET OWNER command' which adds a new ownerType field to the JDO and SQL schemas, and does read and write the field on the ObjectStore.
The ObjectStore will set the ownerType to USER in case the value read is null or empty. This is needed for backward compatibility due to the new schema upgrades.
Modify a couple of tests to verify the ownerType is correctly altered to a ROLE as well.
Diffs
-----
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 6645e551c2299427c61bcf630caeaf8aae6faa82
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MTable.java a38a1250e0ede2b7e294aa1fc326a31fdd8e59f3
standalone-metastore/src/main/resources/package.jdo 221192e37668b4af8dc94add71c148a101f8969e
standalone-metastore/src/main/sql/derby/hive-schema-3.0.0.derby.sql 48d28cb7d8650e988e13950d693fa929849c3b40
standalone-metastore/src/main/sql/derby/upgrade-2.3.0-to-3.0.0.derby.sql b4c46cd237716b86c3f8dca945b81c6f112969fb
standalone-metastore/src/main/sql/mssql/hive-schema-3.0.0.mssql.sql 4c5739f8b37b1b63b59ea3f7211ac53744654442
standalone-metastore/src/main/sql/mssql/upgrade-2.3.0-to-3.0.0.mssql.sql b338f0d061815719447f9bf9d641fffab96543c3
standalone-metastore/src/main/sql/mysql/hive-schema-3.0.0.mysql.sql fd71a1d9b02735770f3885c9cfb67114ce26b542
standalone-metastore/src/main/sql/mysql/upgrade-2.3.0-to-3.0.0.mysql.sql b0d19271e938752f13125c71689ad59aaa775830
standalone-metastore/src/main/sql/oracle/hive-schema-3.0.0.oracle.sql a45c7bbb0fa01969bffdf7bd70b8e8162e973d68
standalone-metastore/src/main/sql/oracle/upgrade-2.3.0-to-3.0.0.oracle.sql 0b7c793f16463d35fab3f4f4968bb642421c12e8
standalone-metastore/src/main/sql/postgres/hive-schema-3.0.0.postgres.sql 2484744adfa0b7ba5163d24c37c1d38f30b44054
standalone-metastore/src/main/sql/postgres/upgrade-2.3.0-to-3.0.0.postgres.sql f06f0dd34e08bfc271e9acd3fa4dde96c695dd98
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java 9490586aafac6452c8265a6c0b9410f5aeda2e7d
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java bdc387e08135102db199776e0b90da2a5616aaf3
Diff: https://reviews.apache.org/r/66909/diff/1/
Testing
-------
Waiting for Hive QA
Thanks,
Sergio Pena