You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Zhen Zhang <ne...@gmail.com> on 2015/03/13 08:28:26 UTC
Review Request 32032: [HELIX-575] Should not send FINALIZED callback
when a bucketized resource is removed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32032/
-----------------------------------------------------------
Review request for helix and Kishore Gopalakrishna.
Repository: helix-git
Description
-------
[HELIX-575] Should not send FINALIZED callback when a bucketized resource is removed
Diffs
-----
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java 65fe2f9
helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java 9b72e41
helix-core/src/test/java/org/apache/helix/integration/ZkIntegrationTestBase.java 8cb697b
helix-core/src/test/java/org/apache/helix/integration/manager/ClusterControllerManager.java b8f0f2b
Diff: https://reviews.apache.org/r/32032/diff/
Testing
-------
mvn test
Thanks,
Zhen Zhang
Re: Review Request 32032: [HELIX-575] Should not send FINALIZED
callback when a bucketized resource is removed
Posted by Kishore Gopalakrishna <ki...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32032/#review76343
-----------------------------------------------------------
Ship it!
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java
<https://reviews.apache.org/r/32032/#comment123907>
we should still invoke the listener when the parent path is deleted right and with finalize.
- Kishore Gopalakrishna
On March 13, 2015, 7:40 a.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32032/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 7:40 a.m.)
>
>
> Review request for helix and Kishore Gopalakrishna.
>
>
> Bugs: HELIX-575
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> [HELIX-575] Should not send FINALIZED callback when a bucketized resource is removed
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java 65fe2f9
> helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java 9b72e41
> helix-core/src/test/java/org/apache/helix/integration/ZkIntegrationTestBase.java 8cb697b
> helix-core/src/test/java/org/apache/helix/integration/manager/ClusterControllerManager.java b8f0f2b
>
> Diff: https://reviews.apache.org/r/32032/diff/
>
>
> Testing
> -------
>
> mvn test
>
>
> Thanks,
>
> Zhen Zhang
>
>
Re: Review Request 32032: [HELIX-575] Should not send FINALIZED
callback when a bucketized resource is removed
Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32032/
-----------------------------------------------------------
(Updated March 13, 2015, 7:40 a.m.)
Review request for helix and Kishore Gopalakrishna.
Bugs: HELIX-575
Repository: helix-git
Description
-------
[HELIX-575] Should not send FINALIZED callback when a bucketized resource is removed
Diffs (updated)
-----
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java 65fe2f9
helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java 9b72e41
helix-core/src/test/java/org/apache/helix/integration/ZkIntegrationTestBase.java 8cb697b
helix-core/src/test/java/org/apache/helix/integration/manager/ClusterControllerManager.java b8f0f2b
Diff: https://reviews.apache.org/r/32032/diff/
Testing
-------
mvn test
Thanks,
Zhen Zhang
Re: Review Request 32032: [HELIX-575] Should not send FINALIZED
callback when a bucketized resource is removed
Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32032/
-----------------------------------------------------------
(Updated March 13, 2015, 7:28 a.m.)
Review request for helix and Kishore Gopalakrishna.
Bugs: HELIX-575
Repository: helix-git
Description
-------
[HELIX-575] Should not send FINALIZED callback when a bucketized resource is removed
Diffs
-----
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java 65fe2f9
helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java 9b72e41
helix-core/src/test/java/org/apache/helix/integration/ZkIntegrationTestBase.java 8cb697b
helix-core/src/test/java/org/apache/helix/integration/manager/ClusterControllerManager.java b8f0f2b
Diff: https://reviews.apache.org/r/32032/diff/
Testing
-------
mvn test
Thanks,
Zhen Zhang